[timelion] Move grammar to package#111881
Conversation
This moves the timelion grammar to a Bazel packages. Generation is managed by Bazel, and the output no longer needs to be committed. Updates can be re-processed by `yarn kbn build` or `yarn kbn watch`. Related to elastic#85341 Closes elastic#17284
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
|
@elastic/kibana-vis-editors this moves grammar generation from pegjs 0.9 to peggy 1.2. I did cursory manual testing, but I'm not sure how far our test coverage extends. If there's any more complicated tests that you're able to validate it would be appreciated. |
|
@elasticmachine merge upstream |
VladLasitsa
left a comment
There was a problem hiding this comment.
GTM, tested locally in chrome, didn't find any issue.
stratoula
left a comment
There was a problem hiding this comment.
Thanx for doing this! Code LGTM. I tested it locally on Safari and everything seems to work fine!
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This moves the timelion grammar to a Bazel packages. Generation is
managed by Bazel, and the output no longer needs to be committed.
Updates can be re-processed by
yarn kbn buildoryarn kbn watch.Related to #85341
Closes #17284