Skip to content

fixes axis title for new axis#10866

Merged
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/newAxisTitle
Mar 24, 2017
Merged

fixes axis title for new axis#10866
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/newAxisTitle

Conversation

@ppisljar
Copy link
Copy Markdown
Contributor

fixes axis title for new axis.

to reproduce:

  • create vert bar chart with date histogram on x axis
  • add second metric (avg of bytes for example) and click "play"
  • go to metrics and axes and for one of the metrics in the axis selection choose "new axis"
  • click "play" ... both axes will have the same title (one of them wrong)

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0 v6.0.0 labels Mar 23, 2017
@ppisljar ppisljar requested a review from thomasneirynck March 23, 2017 12:29
Copy link
Copy Markdown
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI build success

@thomasneirynck
Copy link
Copy Markdown
Contributor

CI failure likely due to maintenance.

jenkins, test this

@ppisljar ppisljar merged commit d8ab1c2 into elastic:master Mar 24, 2017
elastic-jasper added a commit that referenced this pull request Mar 24, 2017
Backports PR #10866

**Commit 1:**
fixes axis title for new axis

* Original sha: 7baa505
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-03-23T12:27:03Z
ppisljar pushed a commit that referenced this pull request Mar 24, 2017
Backports PR #10866

**Commit 1:**
fixes axis title for new axis

* Original sha: 7baa505
* Authored by ppisljar <peter.pisljar@gmail.com> on 2017-03-23T12:27:03Z
simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Mar 27, 2017
simianhacker added a commit that referenced this pull request Mar 28, 2017
…#10890)

* Removing derivative behavior... adding better tooltips to add delete

* Re-organizing metrics; Adding headers; Adding default behavoir

* Adding help text

* Additional fixes

- Fix for deactivated still being able to be added
- Added Experimental Feature to description

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true (#10855)

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* [elasticsearch/healthCheck] fix tests

* [eslint/console] enable no-undef rule (#10881)

* [eslint/console] enable no-undef rule

* [eslint/console] fix no-undef violations

* Navbarextensions improvements (#9871)

* - added controller option
- added $location service to determine on which the user is at currently

* added test for the hideButton method that is dependent on the location path

* removed  argument

* use locals object to pass variables to the template's scope

* use map object

* fixing percentage mode extents (#10843)

* fixes axis title for new axis (#10866)

* fixes metrics options matching (#10865)

* Add kuiLocalTab-isDisabled state. (#10830)

* Add kuiLocalTab-isDisabled state.

* Update Management header to use kuiLocalTab-isDisabled class.

* test: send content-type with proxy POST tests (#10903)

Elasticsearch now requires that content-type be sent on all requests
with payloads, so our tests should be sending it with requests as well.

* [esArchiver] combine elasticDump and ScenarioManager (#10359)

* As a part of bringing functional testing to plugins, esArchiver gives these plugins a way to capture and reload es indexes without needing to write a bunch of custom code. It works similarly to the elasticDump and ScenarioManager tools that it replaces.

Differences:
  - Streaming implementation allows for much larger archives
  - CLI for creating and using archives
  - Configurable archive location
  - Stores the data in gzipped files (better for source control, searching, large archives)
  - Automatically identifies and upgrades Kibana config documents

Methods:
  - `#load(name)`: import an archive
  - `#loadIfNeeded(name)`: import an archive, but skip the documents what belong to any existing index
  - `#unload(name)`: delete the indexes stored in an archive

CLI operations:
  - `./bin/es_archiver save <name> [index patterns...]`: save the mapping and documents in one or more indexes that match the wild-card patterns into an the `<name>` archive
  - `./bin/es_archiver load <name>`: load the mapping and documents from the `<name>` archive

* [functional_tests/common/nagivate] check for statusPage

* [es_archiver] move bins into new scripts dir

* [functional_tests/apps/context] use esArchiver

* [esArchiver] general improvements after showing to a few folks

 - remove auto-upgrading config doc logic (until we have better access to kibana version info)
 - export unload command
 - remove preemptive checks in favor of reacting to errors
 - use type "doc" vs "hit" for doc records (consistency)
 - wrote a bunch of pending tests to think though and plan

* [esArchiver] make log a stream that writes to itself

* [esArchiver] fill in stats and archive format tests

* [esArchiver] splitup action logic

* [esArchiver/cli] fix cli --help output and comment

* [esArchiver] remove type-based param coercion

* [esArchiver/log] use strings for log levels

* [esArchvier] remove unused var

* [esArchiver/indexDocRecordsStream] add tests

* [esArchive] fill in remaining tests

* [esArchiver] fix dem tests

* [eslint] remove unused vars

* [esArchiver/loadIfNeeded] fix call to load()

* [esArchiver] remove loadDumpData helpers
simianhacker added a commit that referenced this pull request Mar 28, 2017
…#10890)

* Removing derivative behavior... adding better tooltips to add delete

* Re-organizing metrics; Adding headers; Adding default behavoir

* Adding help text

* Additional fixes

- Fix for deactivated still being able to be added
- Added Experimental Feature to description

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true (#10855)

* [elasticsearch/healthCheck] ensure that multi.allow_explicit_index=true

* [elasticsearch/healthCheck] fix tests

* [eslint/console] enable no-undef rule (#10881)

* [eslint/console] enable no-undef rule

* [eslint/console] fix no-undef violations

* Navbarextensions improvements (#9871)

* - added controller option
- added $location service to determine on which the user is at currently

* added test for the hideButton method that is dependent on the location path

* removed  argument

* use locals object to pass variables to the template's scope

* use map object

* fixing percentage mode extents (#10843)

* fixes axis title for new axis (#10866)

* fixes metrics options matching (#10865)

* Add kuiLocalTab-isDisabled state. (#10830)

* Add kuiLocalTab-isDisabled state.

* Update Management header to use kuiLocalTab-isDisabled class.

* test: send content-type with proxy POST tests (#10903)

Elasticsearch now requires that content-type be sent on all requests
with payloads, so our tests should be sending it with requests as well.

* [esArchiver] combine elasticDump and ScenarioManager (#10359)

* As a part of bringing functional testing to plugins, esArchiver gives these plugins a way to capture and reload es indexes without needing to write a bunch of custom code. It works similarly to the elasticDump and ScenarioManager tools that it replaces.

Differences:
  - Streaming implementation allows for much larger archives
  - CLI for creating and using archives
  - Configurable archive location
  - Stores the data in gzipped files (better for source control, searching, large archives)
  - Automatically identifies and upgrades Kibana config documents

Methods:
  - `#load(name)`: import an archive
  - `#loadIfNeeded(name)`: import an archive, but skip the documents what belong to any existing index
  - `#unload(name)`: delete the indexes stored in an archive

CLI operations:
  - `./bin/es_archiver save <name> [index patterns...]`: save the mapping and documents in one or more indexes that match the wild-card patterns into an the `<name>` archive
  - `./bin/es_archiver load <name>`: load the mapping and documents from the `<name>` archive

* [functional_tests/common/nagivate] check for statusPage

* [es_archiver] move bins into new scripts dir

* [functional_tests/apps/context] use esArchiver

* [esArchiver] general improvements after showing to a few folks

 - remove auto-upgrading config doc logic (until we have better access to kibana version info)
 - export unload command
 - remove preemptive checks in favor of reacting to errors
 - use type "doc" vs "hit" for doc records (consistency)
 - wrote a bunch of pending tests to think though and plan

* [esArchiver] make log a stream that writes to itself

* [esArchiver] fill in stats and archive format tests

* [esArchiver] splitup action logic

* [esArchiver/cli] fix cli --help output and comment

* [esArchiver] remove type-based param coercion

* [esArchiver/log] use strings for log levels

* [esArchvier] remove unused var

* [esArchiver/indexDocRecordsStream] add tests

* [esArchive] fill in remaining tests

* [esArchiver] fix dem tests

* [eslint] remove unused vars

* [esArchiver/loadIfNeeded] fix call to load()

* [esArchiver] remove loadDumpData helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants