[Security Solution][Detections] Moves last updated info inline with status filter#108096
[Security Solution][Detections] Moves last updated info inline with status filter#108096dplumlee merged 9 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
@elasticmachine merge upstream |
cf6ee50 to
6357660
Compare
There was a problem hiding this comment.
Hey thanks for doing this! Just a quick update. I think you need to get the updatedAt parameter from the table now instead of the the redux selectors. @kqualters-elastic might be able to confirm.
If you take a look at the file associated with the comment here, you'll see what I mean: https://github.com/elastic/kibana/pull/107727/files#r685628747
I would re-introduce that updatedAt property that was removed and thein either use it to update a property in redux or use context to get the data from useTimelineEvents. For sake of ease, I would just store it in context
I would just do what @kqualters-elastic said below
kqualters-elastic
left a comment
There was a problem hiding this comment.
Once the LastUpdatedAt component is used asynchronously, the rest of the changes lgtm
There was a problem hiding this comment.
I know this is by far the easiest way to do this, but the timelines bundle is already much bigger than it should be. Would you mind loading this component in security_solution asynchronously? It's not hard to do, see public/plugin.ts and and public/methods/index.ts for examples. and even just adding this 1 component to the top level public/index.ts increases the bundle size by an almost comical 200kb
bde6c12 to
d82f9fd
Compare
d82f9fd to
5aeb5e0
Compare
Copy logic to tgrid
…to last-updated-redesign
|
Thanks for getting these changes in! @dplumlee and I spoke and we noted the changes that need to be made to update the loading state of the value in an upcoming PR. Just noting: It loads initially based on logic within security solution for the old table, and then shows 52 years due to that information being |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @dplumlee |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Related to #107923 and RAC design updates
Moves the last updated information inline with the status filters on both the alerts page and the rule details page
Screenshots
Checklist
Delete any items that are not applicable to this PR.
For maintainers