[Upgrade Assistant] New ES deprecations page by alisonelizabeth · Pull Request #107053 · elastic/kibana

alisonelizabeth · 2021-07-28T17:11:18Z

This PR updates the ES deprecations page in Upgrade Assistant to align with the new design prototype.

It supports 4 different deprecation "types":

Reindex old indices
Upgrade or delete old ML job model snapshots
Remove deprecated index settings
Default - any other deprecation that doesn't have an automatic resolution associated with it.

This is representative in the code under es_deprecations/deprecation_types.

Technical implementation details:
With the new design, we need to be able to track the status of ML and reindex actions at the row level. This logic was previously encapsulated within a button component (example). This is no longer possible since we need to open the flyout via the "Issue" column and also provide the status of the resolution via the "Resolution" column. In order to achieve this, I built a custom table using EUI components rather than EuiMemoryTable that wraps each applicable row with a context provider. Long term, I think it's worth evaluating if we can keep track of all ML and reindex statuses in a single context, rather than per index name and per ML job ID. However, this requires a fairly significant refactoring that I think is out of scope for this PR.

How to test
Unfortunately, this can only be tested on master with mocked data. That said, I have created a parallel branch based on 7.x that can be used to test the changes against real deprecations.

Check out my 7.x branch and bootstrap.
Unzip 6.8.16-data.zip and start up ES as follows: yarn es snapshot -E path.data=/path/to/6.8.16-data. This contains indices and ML job model snapshots created on 6.8. This will trigger the reindex and ML deprecations.
Start up Kibana, yarn start.
Navigate to Console to trigger other 7.x deprecations. Run the following commands:

// Triggers the deprecated index settings flyout
PUT deprecated_settings
{
  "settings": {
    "translog.retention.size": "1b",
    "translog.retention.age": "5m",
    "index.soft_deletes.enabled": true
  }
}

// Deprecation with no automatic resolution
PUT /nested_multi_fields
{
   "mappings":{
      "properties":{
         "text":{
            "type":"text",
            "fields":{
               "english":{
                  "type":"text",
                  "analyzer":"english",
                  "fields":{
                     "english":{
                        "type":"text",
                        "analyzer":"english"
                     }
                  }
               }
            }
         }
      }
   }
}

// Deprecation with no automatic resolution
PUT field_names_enabled
{
  "mappings": {
    "_field_names": {
      "enabled": false
    }
  }
}

Finally, you're ready to test! Navigate to Upgrade Assistant --> Elasticsearch deprecations.
- Test search, pagination, filtering
- Go through the different deprecations and verify you are able to resolve the ones which provide automatic resolution.
- After resolving an issue, verify the status has been updated. Reopen the flyout, you should not be able to "re-resolve" the deprecation (read-only). Refreshing the data should remove the deprecation from the list.

Deferred work
The following work will be completed in separate PRs:

Functional tests
a11y tests
UI support for resolve_during_rolling_upgrade field - waiting on more information from the ES team about this
"Backup your data" button - waiting on additional feedback as to whether it's necessary to show on this page or not
Bulk reindexing callout - waiting on copy suggestions
Reindexing flyout - the flyout was largely unchanged in this PR. Any design updates will be treated as a separate piece of work.

Screenshots

Overview of changes

// Reindex flyout

// Deprecated index settings flyout

// Default flyout (deprecation does not have automatic resolution)

// ML flyout

// Some resolution states

// Tooltip on Resolution type

// No deprecations

// Invalid search

// Initial loading state

// No search results

…_deprecation_design_updates

alisonelizabeth · 2021-08-17T15:42:22Z

...public/application/components/es_deprecations/deprecation_types/reindex/flyout/container.tsx

@@ -0,0 +1,142 @@
+/*


This file was largely unchanged from es_deprecations/deprecations/reindex/flyout/container.tsx

alisonelizabeth · 2021-08-17T15:44:28Z

...ublic/application/components/es_deprecations/deprecation_types/reindex/use_reindex_state.tsx

@@ -0,0 +1,187 @@
+/*


Refactoring of polling_service.ts. Work initially started as part of #99245.

alisonelizabeth · 2021-08-17T18:15:03Z

@dborodyansky - I have a few outstanding design questions 😄.

Should each "resolution" type have a different icon? I'm currently using the indexSetting icon for all, but I'm not sure that makes sense.

Should the "resolution" type display along with the status (when applicable)? I currently only display the status in this scenario, but can make changes.

Showing the count as well as the "Clear all" option within the "Type" dropdown does not seem possible OOTB with the EUI SearchBar component. AFAICT it only accepts a string value. Do you know if we're doing anything similar in Kibana?

…_deprecation_design_updates

afharo

Telemetry and Core changes LGTM!

@elastic/infra-telemetry Heads up with the removal of some fields and addition of another.

cjcenizal

UX review

Here's a UX review based on testing the PR locally. I'll provide a code review next.

Lost overview information

As I mentioned to @dborodyansky it feels strange to lose pertinent information as we navigate from the Overview page to this page. I'd expect to see a top-level count of critical and non-critical issues. Once we add support for reindexing progress to the Overview page, we should surface it on this page too if it's useful.

Cancelling a reindex looks like an error

If you cancel a reindex, there's a red "x" rendered for the step. I'd expect to see a "Reindex canceled" toast and everything revert to the original state, instead.

Icon positioning

Small nitpick, but I'd expect the "automatable" and "check" icons to both be on the left side in the table rows.

Slight disconnect between reindex callout and acceptable changes

The callout refers to "accepting each change", but the user is left to infer that means checking the boxes of the items below. I think this could be solved as simply as adding a header that says "Changes" or "Accept changes" above the callout.

cjcenizal · 2021-08-17T23:47:17Z

...cation/components/es_deprecations/deprecation_types/index_settings/resolution_table_cell.tsx

+  resolutionTooltipLabel: i18n.translate(
+    'xpack.upgradeAssistant.esDeprecations.indexSettings.resolutionTooltipLabel',
+    {
+      defaultMessage: 'This deprecation requires removing index settings from an index to resolve.',


I'll defer to @debadair if she has a different opinion, but I think this will flow better if we phrase it as guidance: "Resolve this deprecation by...". I think we should also work in the word "automatic" to explain the meaning of the icon. In this case I'd suggest: "Resolve this deprecation by removing settings from this index. This is an automated resolution."

Same suggestion for the other resolution tooltips.

alisonelizabeth · 2021-08-18T17:25:48Z

Thanks @cjcenizal

As I mentioned to @dborodyansky it feels strange to lose pertinent information as we navigate from the Overview page to this page. I'd expect to see a top-level count of critical and non-critical issues. Once we add support for reindexing progress to the Overview page, we should surface it on this page too if it's useful.

++

This is Dmitry's original design:

As mentioned, this doesn't appear to be supported yet in EUI within the Search Bar component. If we feel strongly this is the best approach, I can reach out and see what our options are.

Cancelling a reindex looks like an error

Slight disconnect between reindex callout and acceptable changes

I did not focus on the reindex UX as part of this PR. Will make a note of this to follow up on /cc @yuliacech

Small nitpick, but I'd expect the "automatable" and "check" icons to both be on the left side in the table rows.

👍

cjcenizal · 2021-08-18T18:40:22Z

@alisonelizabeth I also noticed that if you upgrade an ML snapshot, the flyout doesn't surface anything to indicate an upgrade is in progress, and you're still able to click the "Delete" and "Upgrade" buttons. It's not a big deal, it's just a bit of a rough edge in the UX if this upgrade ends up taking loner than expected.

cjcenizal · 2021-08-18T21:29:09Z

Is the checkup_api_response.json fixture still being used? I can't see it being referenced anywhere and I wonder if we can remove it.

cjcenizal

🥂 Great work on this @alisonelizabeth! I had some questions, comments, and suggestions, but no blockers. Personally, I would like to see the file names mirror the names of the code being exported, e.g. table_row.tsx -> reindex_table_row.tsx, but it's NBD.

cjcenizal · 2021-08-18T17:49:02Z

x-pack/plugins/upgrade_assistant/__jest__/client_integration/elasticsearch.test.ts

+
+import { ElasticsearchTestBed, setupElasticsearchPage, setupEnvironment } from './helpers';
+
+describe('Elasticsearch deprecations', () => {


This file is large enough I'm finding it difficult to navigate. What do you think of breaking it up into separate files, similar to what we did with ILM?

In this case I'd suggest breaking it up into 6 files with names that will let me skim the files and get a sense of what's covered and where:

deprecations_table.tsx to test table states and interaction, including search bar, pagination, and empty state

ml_snapshots_deprecation_flyout.tsx to test states of and interaction with the ML Snapshots deprecation

index_settings_deprecation_flyout.tsx to test states of and interaction with the index settings deprecation

reindex_deprecation_flyout.tsx to test states of and interaction with the reindex deprecation -- this is currently light on tests but I expect it will grow

default_deprecation_flyout.tsx to test the content of the default deprecation -- this is currently light on tests but maybe it could grow?

error_handling.tsx

As part of a subsequent scope we could also explore breaking up the helpers files and co-locating them with the tests.

Tests refactored in 037ebb7

cjcenizal · 2021-08-18T17:59:08Z

x-pack/plugins/upgrade_assistant/__jest__/client_integration/elasticsearch.test.ts

+    test('renders deprecations', () => {
+      const { exists, find } = testBed;
+      // Verify container exists
+      expect(exists('esDeprecationsContent')).toBe(true);


Minor suggestion: abstracting these behind helpers like hasPageContainer and getTableRows can make the tests easier to read and reduce the need for explanatory comments.

👍 going to leave as-is for now, will consider refactoring in subsequent PR

cjcenizal · 2021-08-18T18:31:50Z

x-pack/plugins/upgrade_assistant/__jest__/client_integration/elasticsearch.test.ts

+          // Reopen the flyout
+          await actions.clickMlDeprecationAt(0);
+
+          // Flyout actions should not be visible if deprecation was resolved


Thanks for adding all of these great comments! Super-helpful.

cjcenizal · 2021-08-18T18:42:59Z

x-pack/plugins/upgrade_assistant/__jest__/client_integration/elasticsearch.test.ts

+        });
+      });
+
+      describe('reindex deprecation', () => {


Should we add a comment here that the reindexing UX is largely tested by unit tests colocated with the reindex flyout? If we have plans to migrate those tests to CITs it might be mentioning that here as TODO, too.

Thanks for calling this out! I meant to do that actually. I only added one test case for the reindexing flyout, although I think more CITs are warranted. I'd like to treat reindexing as a separate piece of work and add more tests at that time, as I expect the UX to change and some of the existing code to be refactored.

cjcenizal · 2021-08-18T18:45:16Z

x-pack/plugins/upgrade_assistant/__jest__/client_integration/elasticsearch.test.ts

+          '.euiFilterSelect__items .euiFilterSelectItem'
+        );
+
+        expect(clusterTypeFilterButton).not.toBe(null);


FWIW Jest publishes a toBeNull assertion which will surface "nicer error messages" according to the docs: https://jestjs.io/docs/expect#tobenull

cjcenizal · 2021-08-18T22:55:03Z

...ublic/application/components/es_deprecations/deprecation_types/reindex/use_reindex_state.tsx

+  }, [api, indexName, reindexState, updateStatus]);
+
+  const cancelReindex = useCallback(async () => {
+    await api.sendReindexTelemetryData({ stop: true });


cjcenizal · 2021-08-18T22:58:14Z

x-pack/plugins/upgrade_assistant/public/application/lib/api.ts

  }
+
+  public async sendReindexTelemetryData(telemetryData: { [key: string]: boolean }) {
+    const result = await this.sendRequest({


Is it worth wrapping the telemetry requests in a try/catch so we can ignore any errors? Seems like we wouldn't want to disrupt the UX in any way if these fail.

I don't think it's necessary since the send_request util is already wrapping the request in try/catch.

cjcenizal · 2021-08-18T22:59:53Z

x-pack/plugins/upgrade_assistant/server/lib/es_deprecations_status.ts

+
+    return Object.keys(deprecations).reduce((combinedDeprecations, deprecationType) => {
+      if (deprecationType === 'index_settings') {
+        combinedDeprecations = [...combinedDeprecations, ...indices];


The intentions here might be clearer if we use concat:

combinedDeprecations = combinedDeprecations.concat(indices);

cjcenizal · 2021-08-18T23:01:17Z

x-pack/plugins/upgrade_assistant/server/lib/es_deprecations_status.ts

+          }
+        );
+
+        combinedDeprecations = [...combinedDeprecations, ...enrichedDeprecationInfo];


cjcenizal · 2021-08-18T23:02:05Z

x-pack/plugins/upgrade_assistant/server/lib/es_deprecations_status.ts

-    cluster,
-    indices,
+    totalCriticalDeprecations: criticalWarnings.length,
+    deprecations: combinedDeprecations.sort(sortByCritical),


Just curious, why are we sorting on the server if we also sort on the client?

sabarasaba

Awesome work @alisonelizabeth! Tested locally and seems to work well. I left a few nits and suggestions but no blockers. I do would like to see in a subsequent PR the elasticsearch.test.ts being split into smaller files, was a bit hard to follow everything though the comments you left were super helpful!

sabarasaba · 2021-08-18T15:19:36Z

src/core/public/doc_links/doc_links_service.ts

          deprecationLogging: `${ELASTICSEARCH_DOCS}logging.html#deprecation-logging`,
          setupUpgrade: `${ELASTICSEARCH_DOCS}setup-upgrade.html`,
          releaseHighlights: `${ELASTICSEARCH_DOCS}release-highlights.html`,
+          deprecationInfo: `${ELASTICSEARCH_DOCS}migration-api-deprecation.html`,


I think this link isn't being used anymore

sabarasaba · 2021-08-19T08:09:50Z

...assistant/public/application/components/es_deprecations/deprecation_types/default/flyout.tsx

+    }
+  ),
+  closeButtonLabel: i18n.translate(
+    'xpack.upgradeAssistant.esDeprecations.deprecationDetailsFlyout.cancelButtonLabel',


nit: should this be closeButtonLabel instead?

sabarasaba · 2021-08-19T08:16:23Z

...nt/public/application/components/es_deprecations/deprecation_types/index_settings/flyout.tsx

+  removeButtonLabel: i18n.translate(
+    'xpack.upgradeAssistant.esDeprecations.removeSettingsFlyout.removeButtonLabel',
+    {
+      defaultMessage: 'Remove deprecated settings',


nit: maybe we should support singular/plural form in these strings

sabarasaba · 2021-08-19T08:31:29Z

...ns/upgrade_assistant/public/application/components/es_deprecations/es_deprecations_table.tsx

+import { DEPRECATION_TYPE_MAP } from '../constants';
+
+const i18nTexts = {
+  criticalBadgeLabel: i18n.translate(


doesn't seem this one is being used anymore

sabarasaba · 2021-08-19T08:39:35Z

...rade_assistant/public/application/components/overview/review_logs_step/es_stats/es_stats.tsx

-        'This cluster is using {clusterCount} deprecated cluster settings and {indexCount} deprecated index settings',
+  getWarningDeprecationMessage: (warningDeprecations: number) =>
+    i18n.translate('xpack.upgradeAssistant.esDeprecationStats.warningDeprecationsTooltip', {
+      defaultMessage: 'This cluster has {warningDeprecations} non-critical deprecations',


nit: maybe we should support singular/plural form

sabarasaba · 2021-08-19T08:55:41Z

x-pack/plugins/upgrade_assistant/__jest__/client_integration/elasticsearch.test.ts

+          await actions.clickMlDeprecationAt(0);
+
+          // Flyout actions should not be visible if deprecation was resolved
+          expect(find('mlSnapshotDetails.upgradeSnapshotButton').length).toBe(0);


nit: maybe would be more semantically correct if we wrote this like:

expect(exists('mlSnapshotDetails.upgradeSnapshotButton')).toBe(false); expect(exists('mlSnapshotDetails.deleteSnapshotButton')).toBe(false);

sabarasaba · 2021-08-19T09:04:25Z

x-pack/plugins/upgrade_assistant/__jest__/client_integration/elasticsearch.test.ts

+        const { find, actions } = testBed;
+
+        expect(find('esDeprecationsPagination').find('.euiPagination__item').length).toEqual(
+          Math.round(deprecations.length / 50) // Default rows per page is 50


nit: seems kibana deprecations table defaults to 25 (defined in the constants file) but es deprecations table to 50. maybe we should make them default to the same number? and import this DEPRECATIONS_PER_PAGE value in here 🤔

Good catch! After an initial design review with CJ and Dmitry, we decided to change the default number of pages to 50. I'll update the Kibana deprecations to align as part of #109150.

alisonelizabeth · 2021-08-19T19:07:35Z

Thanks for the review @cjcenizal and @sabarasaba! I believe I addressed all of your comments via d253ca0 and 037ebb7.

There are a few items I’d like to follow up on in a separate PR:

Following common pattern for importing .scss files ([Upgrade Assistant] New ES deprecations page #107053 (comment))
Any reindexing-related comments I’d like to defer. I was trying to not touch most of this functionality as part of this PR (although some was necessary in order to get the flyout working with the new design) and treat it as a separate piece of work.
Copy for error messages ([Upgrade Assistant] New ES deprecations page #107053 (comment))
Co-locate helpers in CITs ([Upgrade Assistant] New ES deprecations page #107053 (comment))
Adding steps to test error cases. The readme.md as a whole is outdated, and I’d like to update it to reflect the latest functionality in a separate PR. I’ll add testing steps as part of it. ([Upgrade Assistant] New ES deprecations page #107053 (comment))

alisonelizabeth · 2021-08-19T19:17:39Z

@alisonelizabeth I also noticed that if you upgrade an ML snapshot, the flyout doesn't surface anything to indicate an upgrade is in progress, and you're still able to click the "Delete" and "Upgrade" buttons. It's not a big deal, it's just a bit of a rough edge in the UX if this upgrade ends up taking loner than expected.

@cjcenizal I fixed the issues with the buttons. You bring up a good point though about surfacing progress somewhere. I think this should be addressed separately.

@dborodyansky do you have any thoughts here? Here's a screenshot of the flyout we're discussing - the "upgrade" option could potentially be a long-running task, so if the user reopened the flyout while the upgrade was still in progress it'd be nice to indicate that somewhere.

dborodyansky

Should each "resolution" type have a different icon? I'm currently using the indexSetting icon for all, but I'm not sure that makes sense.

Small nitpick, but I'd expect the "automatable" and "check" icons to both be on the left side in the table rows.

Per follow up discussions, converging on left aligned uniform icons and subdued Manual type, as in the following design:

Should the "resolution" type display along with the status (when applicable)? I currently only display the status in this scenario, but can make changes.

Status replacing resolution type works well in my opinion.

The "upgrade" option could potentially be a long-running task, so if the user reopened the flyout while the upgrade was still in progress it'd be nice to indicate that somewhere.

Same as with reindexing, setting isLoading on the button should give appropriate feedback while process is running.

I'd expect to see a top-level count of critical and non-critical issues. Once we add support for reindexing progress to the Overview page, we should surface it on this page too if it's useful.

Following pattern elsewhere in Kibana, proposing EuiHealth for tally display, in lieu of ability to display counts in filters:

kibanamachine · 2021-08-20T02:51:33Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`upgradeAssistant`	103	108	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`upgradeAssistant`	170.1KB	182.3KB	+12.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`upgradeAssistant`	29.8KB	29.2KB	-650.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`upgrade-assistant-telemetry`	14	13	-1

History

💔 Build #147057 failed 037ebb7
💚 Build #146671 succeeded 123e76a
💔 Build #146637 failed 467b23a
💚 Build #146276 succeeded 1bc44e9
💔 Build #146265 failed b3a22bc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth · 2021-08-20T12:54:05Z

Thanks @dborodyansky for the design feedback! I'm going to go ahead and merge this PR as-is (as it's quite large 😅 ). I've added your comments to the UA planning issue and plan to address early next week.

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecations/reindex/button.tsx # x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecations/reindex/flyout/container.tsx

* [Upgrade Assistant] New ES deprecations page (#107053) # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecations/reindex/button.tsx # x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecations/reindex/flyout/container.tsx * fix linting

alisonelizabeth added 2 commits July 28, 2021 12:05

wip: remove tabs from ES deprecations page

0d3ce81

fix telemetry

9215c68

alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.15.0 labels Jul 28, 2021

wip: implement flyout functionality

32ac42e

alisonelizabeth force-pushed the ua/es_deprecation_design_updates branch from 3b3e9be to 32ac42e Compare August 3, 2021 19:56

alisonelizabeth added 2 commits August 10, 2021 10:15

cleanup

233dad7

Merge branch 'master' of https://github.com/elastic/kibana into ua/es…

37fc0b3

…_deprecation_design_updates

alisonelizabeth mentioned this pull request Aug 11, 2021

[Upgrade Assistant] Improve reindex UX #99245

Closed

alisonelizabeth added 6 commits August 11, 2021 20:32

update existing CITs

ecad28c

update tests

5d3af6b

fix prettier

c863632

address design feedback + more CITs

6d576d2

add resolution column

23d9ca5

Merge branch 'master' of https://github.com/elastic/kibana into ua/es…

b9233ca

…_deprecation_design_updates

alisonelizabeth added v7.16.0 and removed v7.15.0 labels Aug 17, 2021

add more CITs

4a0c371

alisonelizabeth commented Aug 17, 2021

View reviewed changes

alisonelizabeth added 4 commits August 17, 2021 11:52

cleanup

a986dc2

update translations

92dc99f

small design tweaks

b3a22bc

update translations

1bc44e9

alisonelizabeth marked this pull request as ready for review August 17, 2021 18:16

alisonelizabeth requested a review from a team as a code owner August 17, 2021 18:16

alisonelizabeth requested a review from dborodyansky August 17, 2021 18:17

alisonelizabeth changed the title ~~[WIP] [Upgrade Assistant] New ES deprecations page~~ [Upgrade Assistant] New ES deprecations page Aug 17, 2021

Merge branch 'master' of https://github.com/elastic/kibana into ua/es…

467b23a

…_deprecation_design_updates

afharo approved these changes Aug 18, 2021

View reviewed changes

fix i18n

123e76a

cjcenizal reviewed Aug 18, 2021

View reviewed changes

cjcenizal approved these changes Aug 18, 2021

View reviewed changes

alisonelizabeth mentioned this pull request Aug 19, 2021

[Upgrade Assistant] Enable UA for 7.16 #109162

Merged

sabarasaba approved these changes Aug 19, 2021

View reviewed changes

alisonelizabeth added 2 commits August 19, 2021 11:47

address review comments

d253ca0

refactor CITs

037ebb7

dborodyansky approved these changes Aug 19, 2021

View reviewed changes

update jest snapshot

eecfc0c

alisonelizabeth merged commit fcd8970 into elastic:master Aug 20, 2021

alisonelizabeth deleted the ua/es_deprecation_design_updates branch August 20, 2021 12:54

alisonelizabeth mentioned this pull request Aug 20, 2021

[7.x] [Upgrade Assistant] New ES deprecations page (#107053) #109443

Merged

This was referenced Aug 20, 2021

[Upgrade Assistant] Cleanup scss #109524

Merged

[Upgrade Assistant] Refactor CITs #109536

Merged

[Upgrade Assistant] Address design feedback for ES deprecations page #109726

Merged

sabarasaba mentioned this pull request Sep 20, 2021

[Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions #112555

Merged

yuliacech mentioned this pull request Oct 13, 2021

[Upgrade Assistant] Reindexing cancellation #114636

Merged

1 task


		import { ElasticsearchTestBed, setupElasticsearchPage, setupEnvironment } from './helpers';

		describe('Elasticsearch deprecations', () => {

Conversation

alisonelizabeth commented Jul 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth commented Aug 17, 2021

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

UX review

Lost overview information

Cancelling a reindex looks like an error

Icon positioning

Slight disconnect between reindex callout and acceptable changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth commented Aug 18, 2021

Uh oh!

cjcenizal commented Aug 18, 2021

Uh oh!

cjcenizal commented Aug 18, 2021

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Aug 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sabarasaba left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

alisonelizabeth commented Jul 28, 2021 •

edited

Loading

alisonelizabeth Aug 19, 2021 •

edited

Loading

alisonelizabeth commented Aug 19, 2021 •

edited

Loading

alisonelizabeth commented Aug 19, 2021 •

edited

Loading