Skip to content

[Lens] Allows the users to change the axis orientation#106369

Merged
stratoula merged 4 commits intoelastic:masterfrom
stratoula:lens-axis-labelr-orientation
Jul 27, 2021
Merged

[Lens] Allows the users to change the axis orientation#106369
stratoula merged 4 commits intoelastic:masterfrom
stratoula:lens-axis-labelr-orientation

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Jul 21, 2021 •
edited
Loading

Summary

Closes #92574

It adds an additional button group in the axis popover settings. Users can change the orientation of the ticklabels by selecting between 3 options: vertical, horizontal and angled.

image
image

Checklist

Delete any items that are not applicable to this PR.

@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented Jul 26, 2021

@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review July 26, 2021 10:06
@stratoula stratoula requested a review from a team July 26, 2021 10:06
@stratoula stratoula added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Jul 26, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 26, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

dej611
dej611 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Safari 👍

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 26, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 731 732 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 190 191 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.6MB +8.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lens 22 23 +1
Unknown metric groups

API count

id before after diff
lens 206 207 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ryankeairns ryankeairns self-requested a review July 27, 2021 13:05
ryankeairns
ryankeairns approved these changes Jul 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works as expected. Great addition that I think will help us generate some more consistent, better-looking Dashboards, as well.

@stratoula stratoula merged commit c656608 into elastic:master Jul 27, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Jul 27, 2021
@stratoula @kibanamachine
[Lens] Allows the users to change the axis orientation (elastic#106369)
93c5469 
* [Lens] Allows the users to change the axis orientation

* Disable orientation if ticklabels are off

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@stratoula stratoula mentioned this pull request Jul 27, 2021
Merged
stratoula added a commit that referenced this pull request Jul 27, 2021
@stratoula @kibanamachine
[Lens] Allows the users to change the axis orientation (#106369) (#10…
bf706ba 
…6849)

* [Lens] Allows the users to change the axis orientation

* Disable orientation if ticklabels are off

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@stratoula @kibanamachine @vadimkibana
[Lens] Allows the users to change the axis orientation (elastic#106369)
8975a1f 
* [Lens] Allows the users to change the axis orientation

* Disable orientation if ticklabels are off

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@aaron-jencks
Copy link
Copy Markdown

aaron-jencks commented May 29, 2024

did this get disabled somehow? I'm on version 8.9.x and this popover doesn't exist for the heatmap I'm trying to make

@markov00
Copy link
Copy Markdown
Contributor

markov00 commented May 29, 2024

hey @aaron-jencks this is not available in heatmap yet, only on Bar/line/area charts right now. elastic/elastic-charts#1168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@dej611 dej611 dej611 approved these changes

@MichaelMarcialis MichaelMarcialis Awaiting requested review from MichaelMarcialis

Assignees

No one assigned

Labels

Feature:Lens release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] Allow configuration of axis labels orientation

7 participants

@stratoula @elasticmachine @kibanamachine @aaron-jencks @markov00 @ryankeairns @dej611