Skip to content

[Lens] Cleanup bar value labels configuration#106231

Merged
dej611 merged 3 commits intoelastic:masterfrom
dej611:fix/101573
Jul 29, 2021
Merged

[Lens] Cleanup bar value labels configuration#106231
dej611 merged 3 commits intoelastic:masterfrom
dej611:fix/101573

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Jul 20, 2021 •
edited
Loading

Summary

Made this PR as playground for value labels configuration.

Fixes #101573

Winner

Here's the result of the current state of this PR, with the following configuration: outline: off, textContrast: on, invertText: off

Screenshot 2021-07-20 at 13 50 13

Screenshot 2021-07-20 at 13 50 23

Screenshot 2021-07-20 at 13 50 31

Screenshot 2021-07-20 at 13 50 38

(3 votes)

Alternatives considered

Here's a rendering with the current outline enabled: outline: on, textContrast: on, invertText: off

Screenshot 2021-07-20 at 13 53 02

Screenshot 2021-07-20 at 13 53 13

Screenshot 2021-07-20 at 13 53 20

Screenshot 2021-07-20 at 13 53 30

(0 votes)

And at last a rendering with a reduced outline: outline: 1px, textContrast: on, invertText: off

Screenshot 2021-07-20 at 13 55 32

Screenshot 2021-07-20 at 13 55 44

Screenshot 2021-07-20 at 13 55 51

Screenshot 2021-07-20 at 13 56 00

(1 vote)

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 mentioned this pull request Jul 20, 2021
Closed
9 tasks
@stratoula
Copy link
Copy Markdown
Contributor

stratoula commented Jul 21, 2021

I prefer the first one (the current state of the PR). I am not very fond of the outline, and taken under consideration the users' feedback on that I would like to go with the textContrast: on.

@ghudgins
Copy link
Copy Markdown
Contributor

ghudgins commented Jul 22, 2021

1st and 3rd options look good to me.

@dej611 dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement v7.15.0 v8.0.0 labels Jul 28, 2021
@dej611 dej611 marked this pull request as ready for review July 28, 2021 10:00
@dej611 dej611 requested a review from a team July 28, 2021 10:00
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 28, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Jul 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB +90.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 changed the title [Lens] Revisit value labels configuration [Lens] Cleanup bar value labels configuration Jul 28, 2021
@dej611 dej611 merged commit d3e4dcf into elastic:master Jul 29, 2021
@dej611 dej611 deleted the fix/101573 branch July 29, 2021 08:22
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2021
@dej611 @kibanamachine
[Lens] Cleanup bar value labels configuration (elastic#106231)
81368c4 
* 🐛 Rework value labels config

* 📷 Update snapshots
@kibanamachine kibanamachine mentioned this pull request Jul 29, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 29, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 29, 2021
@kibanamachine @dej611
[Lens] Cleanup bar value labels configuration (#106231) (#107125)
44582a2 
* 🐛 Rework value labels config

* 📷 Update snapshots

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@dej611 @vadimkibana
[Lens] Cleanup bar value labels configuration (elastic#106231)
e8ba860 
* 🐛 Rework value labels config

* 📷 Update snapshots
@ghudgins ghudgins mentioned this pull request Aug 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbondyra mbondyra mbondyra approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[XY axis] Values on bar charts

6 participants

@dej611 @stratoula @ghudgins @elasticmachine @kibanamachine @mbondyra