Skip to content

[APM] Add support to upload source map as string or file#105443

Merged
cauemarcondes merged 4 commits intoelastic:masterfrom
cauemarcondes:apm-upload-sourcemap
Jul 16, 2021
Merged

[APM] Add support to upload source map as string or file#105443
cauemarcondes merged 4 commits intoelastic:masterfrom
cauemarcondes:apm-upload-sourcemap

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Jul 13, 2021 •
edited
Loading

The POST /api/apm/sourcemaps API now accepts source map as string or buffer.

Screen Shot 2021-07-13 at 10 10 27

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 labels Jul 13, 2021
@cauemarcondes cauemarcondes requested a review from a team July 13, 2021 14:13
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jul 13, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 13, 2021

Pinging @elastic/apm-ui (Team:apm)

cauemarcondes
cauemarcondes commented Jul 13, 2021
View reviewed changes
@cauemarcondes cauemarcondes mentioned this pull request Jul 13, 2021
Merged
3 tasks
@cauemarcondes cauemarcondes requested a review from dgieselaar July 14, 2021 09:17
dgieselaar
dgieselaar reviewed Jul 14, 2021
View reviewed changes
@cauemarcondes cauemarcondes requested a review from dgieselaar July 14, 2021 18:00
@cauemarcondes cauemarcondes requested a review from dgieselaar July 16, 2021 13:48
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 16, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 16, 2021
@cauemarcondes cauemarcondes merged commit 26c3362 into elastic:master Jul 16, 2021
@cauemarcondes cauemarcondes deleted the apm-upload-sourcemap branch July 16, 2021 15:54
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jul 16, 2021
@cauemarcondes
[APM] Add support to upload source map as string or file (elastic#105443
875a02e 
)

* adding support to upload a sourcemap

* addressing PR comments

* addressing PR comments
@cauemarcondes cauemarcondes mentioned this pull request Jul 16, 2021
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
@cauemarcondes @kibanamachine
[APM] Add support to upload source map as string or file (elastic#105443
1f9ca32 
)

* adding support to upload a sourcemap

* addressing PR comments

* addressing PR comments
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
@cauemarcondes @kibanamachine
[APM] Add support to upload source map as string or file (elastic#105443
cc11565 
)

* adding support to upload a sourcemap

* addressing PR comments

* addressing PR comments
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 16, 2021

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 16, 2021
@kibanamachine @cauemarcondes
[APM] Add support to upload source map as string or file (#105443) (#…
dfc286d 
…105984)

* adding support to upload a sourcemap

* addressing PR comments

* addressing PR comments

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 16, 2021
@kibanamachine @cauemarcondes
[APM] Add support to upload source map as string or file (#105443) (#…
340f273 
…105983)

* adding support to upload a sourcemap

* addressing PR comments

* addressing PR comments

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axw axw axw left review comments

+1 more reviewer

@dgieselaar dgieselaar dgieselaar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.14.0 v7.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cauemarcondes @elasticmachine @kibanamachine @dgieselaar @axw