Skip to content

[ML] Fix Index Data Visualizer error if index pattern has histogram field type#104553

Merged
qn895 merged 4 commits intoelastic:masterfrom
qn895:ml-dv-unsupported-types
Jul 8, 2021
Merged

[ML] Fix Index Data Visualizer error if index pattern has histogram field type#104553
qn895 merged 4 commits intoelastic:masterfrom
qn895:ml-dv-unsupported-types

Conversation

@qn895
Copy link
Copy Markdown
Member

@qn895 qn895 commented Jul 6, 2021 •
edited
Loading

Summary

This PR fixes #102966. Previously, the Index Data Visualizer error out and not load any data if the index pattern selected has any histogram field. This PR adds support for fields with histogram type. This PR also fixes the field types showing types for hidden fields (e.g. _id, _score)

Before
Screen Shot 2021-07-06 at 15 50 27
Note that field types here is showing 3 even though there's only 2 fields

After
Screen Shot 2021-07-07 at 10 22 29

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895 qn895 self-assigned this Jul 6, 2021
@qn895 qn895 added bug Fixes for quality problems that affect the customer experience release_note:fix v7.14.0 v8.0.0 :ml Feature:File and Index Data Viz ML file and index data visualizer labels Jul 6, 2021
@qn895 qn895 marked this pull request as ready for review July 7, 2021 14:10
@qn895 qn895 requested a review from a team as a code owner July 7, 2021 14:10
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2021

Pinging @elastic/ml-ui (:ml)

@spalger spalger added the v7.15.0 label Jul 7, 2021
peteharverson
peteharverson approved these changes Jul 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM

jgowdyelastic
jgowdyelastic approved these changes Jul 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Copy Markdown
Member Author

qn895 commented Jul 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 8, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dataVisualizer 73 104 +31

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 1.1MB 1.1MB -874.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 14.4KB 15.8KB +1.4KB
Unknown metric groups

API count

id before after diff
dataVisualizer 73 104 +31

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 8, 2021
@qn895 qn895 merged commit 035ff66 into elastic:master Jul 8, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@qn895 @kibanamachine
[ML] Fix Index Data Visualizer error if index pattern has histogram f…
bdc4dfc 
…ield type (elastic#104553)

* [ML] Add NON_AGGREGATABLE_FIELD_TYPES, add icon type

* Fix types

* Add histogram icon, fix types showing for hidden fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 8, 2021
@qn895 @kibanamachine
[ML] Fix Index Data Visualizer error if index pattern has histogram f…
6d68696 
…ield type (elastic#104553)

* [ML] Add NON_AGGREGATABLE_FIELD_TYPES, add icon type

* Fix types

* Add histogram icon, fix types showing for hidden fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 8, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 8, 2021

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @qn895
[ML] Fix Index Data Visualizer error if index pattern has histogram f…
fa0e809 
…ield type (#104553) (#104919)

* [ML] Add NON_AGGREGATABLE_FIELD_TYPES, add icon type

* Fix types

* Add histogram icon, fix types showing for hidden fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 8, 2021
@kibanamachine @qn895
[ML] Fix Index Data Visualizer error if index pattern has histogram f…
4b62501 
…ield type (#104553) (#104920)

* [ML] Add NON_AGGREGATABLE_FIELD_TYPES, add icon type

* Fix types

* Add histogram icon, fix types showing for hidden fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
@qn895 qn895 mentioned this pull request Jul 16, 2021
Closed
35 tasks
@qn895 qn895 deleted the ml-dv-unsupported-types branch July 21, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@qn895 qn895

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:fix v7.14.0 v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ML] Index Data Visualizer should support histogram type and better handle unsupported types

6 participants

@qn895 @elasticmachine @kibanamachine @peteharverson @jgowdyelastic @spalger