[Amsterdam theme] Fix issues Index management#103465
Merged
sebelga merged 5 commits intoelastic:masterfrom Jun 30, 2021
Merged
Conversation
11 tasks
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
yuliacech
reviewed
Jun 28, 2021
...lication/components/component_templates/component_template_selector/component_templates.scss
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review @yuliacech ! |
elizabetdev
approved these changes
Jun 29, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! Just looked into the code and screenshots.
...lication/components/component_templates/component_template_selector/component_templates.scss
Outdated
Show resolved
Hide resolved
| panelPaddingSize="none" | ||
| data-test-subj="filterList" | ||
| > | ||
| <div className="euiFilterSelect__items"> |
Contributor
There was a problem hiding this comment.
We normally don't use EUI classes directly here. But I noticed that this was already there and with the time we have left until 7.14 it's ok.
Contributor
Author
There was a problem hiding this comment.
I am not sure why this class was added. I can have a look into it. Will try to merge this first though.
…component_templates/component_template_selector/component_templates.scss Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
Thanks for the review @miukimiu ! |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Jun 30, 2021
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
sebelga
added a commit
that referenced
this pull request
Jun 30, 2021
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Jul 1, 2021
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
sebelga
added a commit
that referenced
this pull request
Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some fixes for the Amsterdam theme in Index management > index template creation wizard.
Component templates - border issue
For the component templates selection there is a search box with a filter button which had some border problem.
Before
After
Component template - dark theme issue
Before
After