Skip to content

[Exploratory view] Update types names#103214

Merged
shahzad31 merged 4 commits intoelastic:masterfrom
shahzad31:improve-naming
Jun 28, 2021
Merged

[Exploratory view] Update types names#103214
shahzad31 merged 4 commits intoelastic:masterfrom
shahzad31:improve-naming

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented Jun 24, 2021 •
edited
Loading

Summary

Improve naming in exploratory view for variable and series configuration.

renamed types

DataSeries --> SeriesConfig
breakdowns --> breakdownFields
defaultFilters --> filterFields
filters --> baseFilters
reportDefinitions --> definitionFields

have moved custom report def which is a metric options to a separate field
as metricOptions.

Testing

as long as unit tests are passing, so i have a good confident in this PR

@shahzad31 shahzad31 changed the title update underlying structure [Exploratory view] Update types names Jun 24, 2021
@shahzad31 shahzad31 marked this pull request as ready for review June 24, 2021 15:05
@shahzad31 shahzad31 self-assigned this Jun 24, 2021
@shahzad31 shahzad31 added v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jun 24, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 24, 2021

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 mentioned this pull request Jun 28, 2021
Merged
dominiqueclarke
dominiqueclarke reviewed Jun 28, 2021
View reviewed changes
...servability/public/components/shared/exploratory_view/configurations/lens_attributes.test.ts
dataType: 'number',
isBucketed: true,
label: 'Largest contentful paint',
label: 'Page load time',
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed along with sourceField in this test?

Copy link
Copy Markdown
Contributor Author

@shahzad31 shahzad31 Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's related to the metric options. With this change, it selects the first by default. Earlier that wasn't happening, this is why test was selecting a different metric. Now the test is updated correctly.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 28, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 206 207 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 474.0KB 472.2KB -1.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 54.6KB 54.8KB +164.0B
Unknown metric groups

API count

id before after diff
observability 206 207 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke
dominiqueclarke approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test LGTM

@shahzad31 shahzad31 merged commit 4f45535 into elastic:master Jun 28, 2021
@shahzad31 shahzad31 deleted the improve-naming branch June 28, 2021 13:55
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 28, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 28, 2021
@shahzad31 @kibanamachine
[Exploratory view] Update types names (elastic#103214)
ea0e164
@kibanamachine kibanamachine mentioned this pull request Jun 28, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 28, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 28, 2021
@kibanamachine @shahzad31
[Exploratory view] Update types names (#103214) (#103483)
b6943f9 
Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shahzad31 @elasticmachine @kibanamachine @dominiqueclarke @justinkambic