[Page layouts] Some light fixes#103197
Merged
myasonik merged 22 commits intoelastic:masterfrom Jun 30, 2021
Merged
Conversation
added 14 commits
June 23, 2021 13:37
16 tasks
pgayvallet
approved these changes
Jun 24, 2021
cchaos
commented
Jun 24, 2021
x-pack/plugins/ml/public/application/components/navigation_menu/main_tabs.tsx
Show resolved
Hide resolved
sabarasaba
approved these changes
Jun 28, 2021
Member
sabarasaba
left a comment
There was a problem hiding this comment.
kibana stack management changes LGTM 🚀
weltenwort
approved these changes
Jun 28, 2021
Member
weltenwort
left a comment
There was a problem hiding this comment.
infra plugin changes LGTM, thank you!
jloleysens
approved these changes
Jun 29, 2021
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
App services changes LGTM 🍻
peteharverson
approved these changes
Jun 29, 2021
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest ML edits and LGTM
Contributor
|
@elasticmachine merge upstream |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
💔 Backport failed
To backport manually run: |
snide
added a commit
that referenced
this pull request
Jun 30, 2021
* [Solution Toolbar] Fixing button border on non-text color versions * [Alerts] Removed extra wrappers and use EuiPageHeader * [Logstash] Basic conversion to template * [Reporting] Adding bottomBorder to page header * [ML] Fix display of main navigation tabs * [Stack Management] Fix side nav not updating when going back to landing page * [Tags] Add spacing after page header * [License Management] Full width on file uploader * [Page Template] Fixed `emptyState` default template for pages with side nav * [Infra] Removing some page header displays in empty states * [Enterprise Search] Fix some error layouts * [Index Patterns] Quick fix for empty state * snaps * [Page Template] Remove forced padding when `centeredBody` * small hack for tab padding for ml * scroll ML page to fix test * fix test method type signature Co-authored-by: Dave Snider <dave.snider@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly trying to better adhere to the Page Layout Guidelines and fixing a few things that were not caught in the conversion.
The big change, is that the KibanaPageTemplate was using the wrong default template type for
emptyStatewhen there was a sidebar. It should always becenteredContentnevercenteredBody.Before
After
Including loading screens
Checklist
Delete any items that are not applicable to this PR.