Skip to content

remove or replace xs props for text on source connect view#102663

Merged
zombieFox merged 2 commits intoelastic:masterfrom
zombieFox:fix/1786-small-font-size-on-source-connection-page
Jun 18, 2021
Merged

remove or replace xs props for text on source connect view#102663
zombieFox merged 2 commits intoelastic:masterfrom
zombieFox:fix/1786-small-font-size-on-source-connection-page

Conversation

@zombieFox
Copy link
Copy Markdown
Contributor

@zombieFox zombieFox commented Jun 18, 2021

Summary

Closes workplace-search-team #1786

This PR fixes a font size issue by increases the size of text on the source connect view in Workplace Search.

Old New
localhost_5601_znc_app_enterprise_search_workplace_search_sources_add_confluence_cloud_connect (1) localhost_5601_znc_app_enterprise_search_workplace_search_sources_add_confluence_cloud_connect

Checklist

Delete any items that are not applicable to this PR.

@zombieFox zombieFox requested a review from a team June 18, 2021 17:25
@zombieFox zombieFox added v7.14.0 release_note:skip Skip the PR/issue when compiling release notes bug Fixes for quality problems that affect the customer experience auto-backport Deprecated - use backport:version if exact versions are needed and removed bug Fixes for quality problems that affect the customer experience labels Jun 18, 2021
Copy link
Copy Markdown
Contributor

@yakhinvadim yakhinvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB -237.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@zombieFox zombieFox merged commit 31aa1c8 into elastic:master Jun 18, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 18, 2021
…ect view (elastic#102663)

* remove xs props for text on source connect view

* change more text sizes
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 18, 2021
…ect view (#102663) (#102670)

* remove xs props for text on source connect view

* change more text sizes

Co-authored-by: Kuldeep M <crudetoaster@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 21, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (447 commits)
  skip flaky suite (elastic#102366)
  [Security Solution][Endpoint][Host Isolation] Isolation status badge from alert details (elastic#102274)
  Add email connector info for Elastic Cloud (elastic#91363)
  [Workplace Search] remove or replace xs props for text on source connect view (elastic#102663)
  Do not double register dashboard url generator (elastic#102599)
  [TSVB] Replaces EuiCodeEditor 👉 Monaco editor  (elastic#100684)
  [Discover] Update kibana.json adding owner and description (elastic#102292)
  [Exploratory View] Mobile experience (elastic#99565)
  chore(NA): moving @kbn/ui-shared-deps into bazel (elastic#101669)
  [TSVB] Index pattern select field disappear in Annotation tab (elastic#102314)
  [Security Solution][Endpoint][Host Isolation] Fixes bug where host isolation/unisolation works from alert details (elastic#102581)
  TSVB visualizations with no timefield do not render after upgrading from 7.12.1 to 7.13.0 (elastic#102494)
  [Logs UI] Add `event.original` fallback to message reconstruction rules (elastic#102236)
  [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506)
  [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384)
  [ML] Anomaly detection job custom_settings improvements (elastic#102099)
  [Cases] Route: Get all alerts attach to a case (elastic#101878)
  Fixes wrong list exception type when creating endpoint event filters list (elastic#102522)
  remove search bar that's not working yet (elastic#102550)
  Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants