[Security Solution][Endpoint] Suppress some of the jest console.error noise created by endpoint list middelware#102535
Merged
paul-tavares merged 5 commits intoelastic:masterfrom Jun 17, 2021
Conversation
…or noise in endpoint host tests
…rrors to the console
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
paul-tavares
commented
Jun 17, 2021
| export type ApiHandlerMock<R extends ResponseProvidersInterface = ResponseProvidersInterface> = ( | ||
| http: jest.Mocked<HttpStart> | ||
| http: jest.Mocked<HttpStart>, | ||
| options?: { ignoreUnMockedApiRouteErrors?: boolean } |
Contributor
Author
There was a problem hiding this comment.
Although I added this here, we probably don't want to use it often. Having the errors come out on the console when working on specific test cases is likely desired so that you are aware of what is not mocked from an API standpoint
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 17, 2021
… noise created by endpoint list middelware (elastic#102535) * Mock KibanaServices with services from app context renderer + fix error noise in endpoint host tests * silence more error noise to the console * Added options to the ApiHandlerMock function to be able to suppress errors to the console * Endpoint list - Refactor Fleet mocks for reuse * Add default http mocks to the app context render test utility
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
parkiino
approved these changes
Jun 17, 2021
Contributor
parkiino
left a comment
There was a problem hiding this comment.
lol i see that you already merged but yayay for no more console warningss
kibanamachine
added a commit
that referenced
this pull request
Jun 17, 2021
… noise created by endpoint list middelware (#102535) (#102561) * Mock KibanaServices with services from app context renderer + fix error noise in endpoint host tests * silence more error noise to the console * Added options to the ApiHandlerMock function to be able to suppress errors to the console * Endpoint list - Refactor Fleet mocks for reuse * Add default http mocks to the app context render test utility Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 18, 2021
…ets-tab * 'master' of github.com:elastic/kibana: (93 commits) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) [Maps] clean up feature editing name space to avoid conflicts with layer settings editing (elastic#102516) [canvas] Refactor Storybook from bespoke to standard configuration (elastic#101962) [Security Solution] adds wrapSequences method (RAC) (elastic#102106) [FTR] Stabilize SSLP functional tests (elastic#102553) [K8] Added `Inter` font files for new theme (elastic#102359) [Workplace Search] Convert Groups pages to new page template (elastic#102449) [DOC] Add experimental disclaimer to rollup jobs (elastic#95624) [Security Solution][Endpoint] Suppress some of the jest console.error noise created by endpoint list middelware (elastic#102535) [Fleet] Improve performance of Fleet setup (elastic#102219) [Alerting] Add event log entry when a rule starts executing (elastic#102001) [Fleet] Update docker image of registry used in integration tests (elastic#101911) [Asset Management] Osquery telemetry updates (elastic#100754) Converts saved object tagging to new management layout (elastic#102284) ... # Conflicts: # x-pack/plugins/fleet/kibana.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary