Skip to content

[License management] Migrate to new page layout#102218

Merged
sabarasaba merged 12 commits intoelastic:masterfrom
sabarasaba:licence-management/new_layout
Jun 22, 2021
Merged

[License management] Migrate to new page layout#102218
sabarasaba merged 12 commits intoelastic:masterfrom
sabarasaba:licence-management/new_layout

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Jun 15, 2021 •
edited
Loading

This PR migrates Ingest License Management to use the new page layout. I made a few minor UX changes, license icon/title/description has been moved to an EuiPageHeader component and cards with actions have now a border instead of a shadow. New designs for the dashboard view have been double checked by @cchaos

Related: #100748

Screenshots

Dashboard

Screenshot 2021-06-17 at 11 09 19
Screenshot 2021-06-17 at 11 10 05

Upload License

Screenshot 2021-06-15 at 16 12 35

Permissions check

Screenshot 2021-06-15 at 16 13 38
Screenshot 2021-06-15 at 16 14 15
Screenshot 2021-06-15 at 16 14 35

@sabarasaba sabarasaba self-assigned this Jun 15, 2021
@sabarasaba sabarasaba mentioned this pull request Jun 15, 2021
Closed
10 tasks
@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Jun 17, 2021

@elasticmachine merge upstream

@sabarasaba sabarasaba added chore Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.14.0 v8.0.0 labels Jun 17, 2021
@sabarasaba sabarasaba marked this pull request as ready for review June 17, 2021 09:31
@sabarasaba sabarasaba requested a review from a team as a code owner June 17, 2021 09:31
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 17, 2021

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Jun 17, 2021

@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth approved these changes Jun 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sabarasaba! Overall LGTM. I left a few comments in the code; the only ones I feel strongly about are the comments related to a11y.

...license_management/public/application/sections/license_dashboard/start_trial/start_trial.tsx
<EuiFlexItem>
{this.acknowledgeModal(dependencies!.docLinks)}
<EuiCard
// @ts-ignore - Known issue from EUI, while they fix their types I've been told that we can just ignore this for now.
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an open issue we can link to in the comment?

Copy link
Copy Markdown
Member Author

@sabarasaba sabarasaba Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it got fixed in this PR from EUI, so we just need to wait until the changes get released from EUI and version bumped in kibana. I asked around to see if that would happen before CF.

@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Jun 18, 2021

@elasticmachine merge upstream

@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Jun 21, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 21, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
licenseManagement 145 146 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
licenseManagement 124.0KB 127.0KB +3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
licenseManagement 17.6KB 17.9KB +303.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@cjcenizal
Copy link
Copy Markdown
Contributor

cjcenizal commented Jun 21, 2021

Nice work @sabarasaba!

@sabarasaba sabarasaba merged commit e806dde into elastic:master Jun 22, 2021
@sabarasaba sabarasaba mentioned this pull request Jun 22, 2021
Merged
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Jun 22, 2021
@sabarasaba @kibanamachine
[License management] Migrate to new page layout (elastic#102218)
77768ed 
* start working on license management

* migrate permissions check to new layout

* refactor license expiration as a subtitle of the page header

* finish up working on page title

* Fix linter errors and update snapshots

* update method name

* CR changes

* update snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
sabarasaba added a commit that referenced this pull request Jun 22, 2021
@sabarasaba @kibanamachine
[License management] Migrate to new page layout (#102218) (#102856)
db992d9 
* start working on license management

* migrate permissions check to new layout

* refactor license expiration as a subtitle of the page header

* finish up working on page title

* Fix linter errors and update snapshots

* update method name

* CR changes

* update snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

@sabarasaba sabarasaba

Labels

chore Feature:License release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sabarasaba @elasticmachine @kibanamachine @cjcenizal @alisonelizabeth