[5.x] Add landing page with table to Visualize app.#10212
Merged
Conversation
08e498b to
eb2999f
Compare
Backports PR #9605 **Commit 1:** Refactor Visualize Wizard to use explicit controller names, instead of defining them dynamically. * Original sha: 5778951 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-21T20:58:55Z **Commit 2:** Add landing page with table to Visualize app. - Update Visualize wizard UI. - kbnTopNav directive supports no-menu-extensions attribute for excluding extensions, so you can hide the menu items entirely. * Original sha: 5a5eecb * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-22T00:08:06Z **Commit 3:** Add kuiIcon--basic and support icons in Table component. Display icons in Visualize landing page. * Original sha: 1dbffd1 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-22T01:38:35Z **Commit 4:** Fix bug with vertical alignment in Table cells. * Original sha: f69df4c * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-22T01:41:56Z **Commit 5:** Change Visualize menu items: New goes to landing page, Open goes to wizard. * Original sha: 8ca2faf * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-22T01:46:22Z **Commit 6:** Move visualize/landing route to live at visualize/ instead. * Original sha: e674f6c * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-23T21:46:21Z **Commit 7:** Refactor Visualize Wizard templates to use import syntax. * Original sha: b129af5 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-23T21:48:11Z **Commit 8:** Set kuiViewContent width to 100% to avoid it shrink wrapping its content. * Original sha: 94afb6f * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-23T22:00:36Z **Commit 9:** Move ToolBar buttons to the right side. Remove labels and add tooltips. * Original sha: 6a66f6f * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-23T22:04:49Z **Commit 10:** Fix functional tests for Visualize, to work with new landing page. * Original sha: 5a720c9 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-23T23:47:52Z **Commit 11:** Remove unused Visualize load menu template. * Original sha: b010488 * Authored by CJ Cenizal <cj@cenizal.com> on 2016-12-23T23:52:24Z **Commit 12:** Remove Edit link from Visualization listing. * Original sha: a1f737f * Authored by CJ Cenizal <cj@cenizal.com> on 2017-01-03T19:41:50Z **Commit 13:** Disable timepicker in Visualization listing. * Original sha: ca4adc3 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-01-05T00:18:35Z **Commit 14:** Add basic Icon example. Fix Visualize Wizard titles and layout. * Original sha: 50e2da7 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-01-17T16:57:31Z **Commit 15:** Remove icon cells from Table component. Fix Visualize landing table header bug and type icon position. * Original sha: 5625264 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-01T18:19:49Z **Commit 16:** Change Visualize route names. Add omitPages attribute to breadcrumbs directive. Make Visualize breadcrumbs into links. * Original sha: 93c9533 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-02T00:41:07Z **Commit 17:** Remove Open and New menu buttons from Visualize. * Original sha: f243762 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-02T01:07:55Z **Commit 18:** Add ConfirmationModal for deleting visualizations. * Original sha: d0325ba * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-02T01:14:34Z **Commit 19:** Implement sorting for name and type columns in Visualize listing. * Original sha: 39ed424 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-02T01:21:57Z **Commit 20:** Refactor Visualize routes into VisualizeConstants file. Fix functional tests. * Original sha: 43ceb6e * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-02T18:45:17Z **Commit 21:** Add pager_controls directive and pager service. Add pagination to Dashboard and Visualize landing pages. Change Dashboard listing to use hrefs for each dashboard. * Original sha: d1d3da7 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-04T00:37:28Z **Commit 22:** Add Basic Icon example. * Original sha: 880b7b4 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-04T00:41:59Z **Commit 23:** Use ng-if instead of ng-hide to hide/reveal Table action buttons in Dashboard listing. * Original sha: 668d598 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-04T00:44:06Z **Commit 24:** Redirect from old Visualize wizard routes to new ones. * Original sha: 99525ac * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-06T18:37:05Z **Commit 25:** Use ViewContent and Title components in Visualize wizard. * Original sha: 734c85b * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-06T18:46:50Z **Commit 26:** Fix Visualize and Dashboard listing table logic so that selection only applies to the current page of items. - Paging clears the selection. - Searching clears the selection. - Sorting clears the selection. * Original sha: de4f7b4 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-06T19:05:16Z **Commit 27:** - Fix Visualize wizard breadcrumbs. - Use consistent "Create" terminology in both Visualize and Dashboard for creating new items. - Use NoItems and PromptForItems components in Visualize listing view. * Original sha: 10dbff6 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-06T19:22:09Z **Commit 28:** Rename pagerService factory to pagerFactory. * Original sha: 6eeeab6 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-06T19:29:36Z **Commit 29:** Minor code style improvements. * Original sha: 438f5c4 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-06T19:36:17Z **Commit 30:** Use inject dependencies in Visualize and Dashboard listing. * Original sha: 794b18c * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-06T19:45:00Z
eb2999f to
f32de35
Compare
Contributor
|
jenkins, test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add landing page with table to Visualize app.
Backports PR #9605
Commit 1:
Refactor Visualize Wizard to use explicit controller names, instead of defining them dynamically.
Commit 2:
Add landing page with table to Visualize app.
Commit 3:
Add kuiIcon--basic and support icons in Table component. Display icons in Visualize landing page.
Commit 4:
Fix bug with vertical alignment in Table cells.
Commit 5:
Change Visualize menu items: New goes to landing page, Open goes to wizard.
Commit 6:
Move visualize/landing route to live at visualize/ instead.
Commit 7:
Refactor Visualize Wizard templates to use import syntax.
Commit 8:
Set kuiViewContent width to 100% to avoid it shrink wrapping its content.
Commit 9:
Move ToolBar buttons to the right side. Remove labels and add tooltips.
Commit 10:
Fix functional tests for Visualize, to work with new landing page.
Commit 11:
Remove unused Visualize load menu template.
Commit 12:
Remove Edit link from Visualization listing.
Commit 13:
Disable timepicker in Visualization listing.
Commit 14:
Add basic Icon example. Fix Visualize Wizard titles and layout.
Commit 15:
Remove icon cells from Table component. Fix Visualize landing table header bug and type icon position.
Commit 16:
Change Visualize route names. Add omitPages attribute to breadcrumbs directive. Make Visualize breadcrumbs into links.
Commit 17:
Remove Open and New menu buttons from Visualize.
Commit 18:
Add ConfirmationModal for deleting visualizations.
Commit 19:
Implement sorting for name and type columns in Visualize listing.
Commit 20:
Refactor Visualize routes into VisualizeConstants file. Fix functional tests.
Commit 21:
Add pager_controls directive and pager service. Add pagination to Dashboard and Visualize landing pages. Change Dashboard listing to use hrefs for each dashboard.
Commit 22:
Add Basic Icon example.
Commit 23:
Use ng-if instead of ng-hide to hide/reveal Table action buttons in Dashboard listing.
Commit 24:
Redirect from old Visualize wizard routes to new ones.
Commit 25:
Use ViewContent and Title components in Visualize wizard.
Commit 26:
Fix Visualize and Dashboard listing table logic so that selection only applies to the current page of items.
Commit 27:
Commit 28:
Rename pagerService factory to pagerFactory.
Commit 29:
Minor code style improvements.
Commit 30:
Use inject dependencies in Visualize and Dashboard listing.