Remove Open and New menu buttons from Visualize.

cjcenizal · cjcenizal · commit f243762d8f9a · 2017-02-03T16:40:46.000-08:00
diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.js b/src/core_plugins/kibana/public/visualize/editor/editor.js
@@ -104,20 +104,10 @@ function VisEditor($scope, $route, timefilter, AppState, $window, kbnUrl, courie
   const searchSource = savedVis.searchSource;
 
   $scope.topNavMenu = [{
-    key: 'new',
-    description: 'New Visualization',
-    run: function () { kbnUrl.change('/visualize/step/1', {}); },
-    testId: 'visualizeNewButton',
-  }, {
     key: 'save',
     description: 'Save Visualization',
     template: require('plugins/kibana/visualize/editor/panels/save.html'),
     testId: 'visualizeSaveButton',
-  }, {
-    key: 'open',
-    description: 'Open Saved Visualization',
-    run: function () { kbnUrl.change('/visualize', {}); },
-    testId: 'visualizeOpenButton',
   }, {
     key: 'share',
     description: 'Share Visualization',
@@ -225,7 +215,7 @@ function VisEditor($scope, $route, timefilter, AppState, $window, kbnUrl, courie
     $state.replace();
 
     $scope.getVisualizationTitle = function getVisualizationTitle() {
-      return savedVis.lastSavedTitle || 'New Visualization';
+      return savedVis.lastSavedTitle || `${savedVis.title} (unsaved)`;
     };
 
     $scope.$watch('searchSource.get("index").timeFieldName', function (timeField) {
diff --git a/test/support/page_objects/visualize_page.js b/test/support/page_objects/visualize_page.js
@@ -296,11 +296,6 @@ export default class VisualizePage {
     });
   }
 
-  clickNewVisualization() {
-    return PageObjects.common.findTestSubject('visualizeNewButton')
-    .click();
-  }
-
   saveVisualization(vizName) {
     return PageObjects.common.findTestSubject('visualizeSaveButton')
     .click()
@@ -337,7 +332,11 @@ export default class VisualizePage {
   }
 
   clickLoadSavedVisButton() {
-    return PageObjects.common.findTestSubject('visualizeOpenButton')
+    // TODO: Use a test subject selector once we rewrite breadcrumbs to accept each breadcrumb
+    // element as a child instead of building the breadcrumbs dynamically.
+    return self.remote
+      .setFindTimeout(defaultFindTimeout)
+      .findByCssSelector('[href="#/visualize"]')
       .click();
   }
 
