[Remote Clusters] Migrate to new page layout#102042
Merged
sabarasaba merged 7 commits intoelastic:masterfrom Jun 15, 2021
Merged
[Remote Clusters] Migrate to new page layout#102042sabarasaba merged 7 commits intoelastic:masterfrom
sabarasaba merged 7 commits intoelastic:masterfrom
Conversation
10 tasks
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
Member
Author
|
@elasticmachine merge upstream |
alisonelizabeth
approved these changes
Jun 14, 2021
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
Great work @sabarasaba! I left a couple minor comments in the code.
I also noticed a few UX discrepancies compared with our other apps. I think this was all pre-existing behavior though, so I can open up a separate issue to address.
- It seemed strange to have the error prompt as well as a toast notification. I think the prompt is sufficient.
- In most of our UIs, we have a doc link to the left of the page header and the action button ("Create a remote cluster") is right-aligned to the search input.
...ugins/remote_clusters/public/application/sections/remote_cluster_edit/remote_cluster_edit.js
Outdated
Show resolved
Hide resolved
...ugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_list.js
Outdated
Show resolved
Hide resolved
...ugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_list.js
Outdated
Show resolved
Hide resolved
Member
Author
|
@alisonelizabeth Thanks for having a look! The 2 extra changes were small enough that I felt could be included in this PR, lmkwyt |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
Contributor
👍 Thanks! Changes LGTM. |
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Jun 15, 2021
* change page templates * Small copy tweaks * Update docs * small CR changes * exit function call if fails * update i18n strings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
sabarasaba
added a commit
that referenced
this pull request
Jun 15, 2021
* change page templates * Small copy tweaks * Update docs * small CR changes * exit function call if fails * update i18n strings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Jun 15, 2021
* change page templates * Small copy tweaks * Update docs * small CR changes * exit function call if fails * update i18n strings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates
Remote Clustersto use the new page layout.Related: #100748
Screenshots
List
Create
Edit