[Upgrade Assistant] Migrate to new page layout#101691
Merged
alisonelizabeth merged 7 commits intoelastic:masterfrom Jun 10, 2021
Merged
[Upgrade Assistant] Migrate to new page layout#101691alisonelizabeth merged 7 commits intoelastic:masterfrom
alisonelizabeth merged 7 commits intoelastic:masterfrom
Conversation
10 tasks
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
cjcenizal
approved these changes
Jun 10, 2021
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally, code LGTM! Thanks for doing this, Alison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates Upgrade Assistant to use the new page layout.
Related to #100748
For testing, if you need to mock ES deprecation data, you can use this gist.
Notes on approach:
I largely followed the guidelines in #101335. However, for tabbed content, I kept the existing behavior for empty and error states. I don't think we can completely get rid of the page title as suggested in cchaos#28 (comment), as the empty/error state is within the context of the tab. Also note that we have plans to eventually remove the tabs in UA, so this will likely change again.
Screenshots
Overview page:
ES deprecations:
Kibana deprecations:
