Convert security management pages to new layout by legrego · Pull Request #101660 · elastic/kibana

legrego · 2021-06-08T18:58:20Z

Summary

Updates the security stack management apps to conform to the new layout as outlined in #101336

Users

Roles

Role mappings

API Keys

Spaces

legrego · 2021-06-09T13:00:07Z

...ity/public/management/role_mappings/components/no_compatible_realms/no_compatible_realms.tsx

        <FormattedMessage
          id="xpack.security.management.roleMappings.noCompatibleRealmsErrorTitle"
-          defaultMessage="No compatible realms are enabled in Elasticsearch"
+          defaultMessage="No compatible realms appear to be enabled in Elasticsearch"


This wasn't necessary, but it softens the language because we aren't 100% sure that there aren't any compatible realms

elasticmachine · 2021-06-09T14:05:53Z

Pinging @elastic/kibana-security (Team:Security)

cchaos

I'm seeing a flash of a loading screen that looks to still be rendering the EuiPage component. Specifically when I click the "Create role mapping" button.

The others are mostly minor comments. But overall this looks great. Thank you!!!

.../security/public/management/role_mappings/components/permission_denied/permission_denied.tsx

...lugins/security/public/management/role_mappings/edit_role_mapping/edit_role_mapping_page.tsx

x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx

...ns/security/public/management/api_keys/api_keys_grid/permission_denied/permission_denied.tsx

.../plugins/security/public/management/roles/roles_grid/permission_denied/permission_denied.tsx

x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx

x-pack/plugins/spaces/public/management/edit_space/manage_space_page.tsx

x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx

…ent-page-conversions

cchaos

Updates look great to me. Thanks @legrego !!

legrego · 2021-06-16T11:31:16Z

@elasticmachine merge upstream

legrego · 2021-06-16T13:06:34Z

@elasticmachine merge upstream

legrego · 2021-06-17T14:57:13Z

@watson this is ready for review if you have a chance to take a look

legrego · 2021-06-17T14:57:24Z

@elasticmachine merge upstream

legrego · 2021-06-21T11:23:36Z

@elasticmachine merge upstream

thomheymann · 2021-06-21T12:11:15Z

x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx

    if (!isLoadingTable && apiKeys && apiKeys.length === 0) {
      return (
-        <EuiPageContent>
+        <EuiPageContent verticalPosition="center" horizontalPosition="center" color="subdued">


@cchaos Should the create button in the empty prompt use the same "iconInCircleFilled" icon as the ones in the header on the index page? Seems a bit inconsistent but it's displayed that way in the meta issue too.

Ah I pushed a commit for this before I realized you asked @cchaos for input. I updated this to be plusInCircleFilled as that's consistent with the other "Create" buttons, but I'm happy to adjust as necessary

For fill style buttons, the Filled icon is best :) sorry for the late response

@cchaos Sorry, I was talking about the empty prompts.

We show an icon in the CTA on the index pages:

But we do not do that for the empty state:

Seems inconsistent and I was wondering if that's intentional.

THere's no real pattern for the empty state version of CTA's. You can add one if you'd like. I wouldn't hold up this PR for it though 😉

…ent-page-conversions

…o/kibana into chore/management-page-conversions

legrego · 2021-06-23T19:41:31Z

@elasticmachine merge upstream

thomheymann

Looks great - so much nicer than before! 🙌

I noticed a couple small issues.

The panels at the bottom of the user form seem to be stretching out in height now which they didn't before and looks off:

If I read @cchaos earlier comment correctly we should be using filled icon styles for filled buttons and outlined icons for the ones inside role management:

If that's not the case then we should update role mappings form as well but I think outlined icon looks better for unfilled buttons:

thomheymann · 2021-06-24T08:35:15Z

.../public/management/role_mappings/edit_role_mapping/mapping_info_panel/mapping_info_panel.tsx

  public render() {
    return (
-      <EuiPanel>
+      <EuiPanel hasShadow={false} hasBorder={true}>


nit: I think hasShadow defaults to false when hasBorder is enabled so you could simplify this to:

<EuiPanel hasBorder>

…ent-page-conversions

…o/kibana into chore/management-page-conversions

legrego · 2021-06-24T17:40:32Z

@thomheymann thanks for the review! I updated the edit role screen to use outlined icons in its buttons for consistency, as you suggested. As for the actions on the user management page, I wasn't able to reproduce the stretched layout that you experienced:

legrego · 2021-06-28T11:24:58Z

@elasticmachine merge upstream

…ent-page-conversions

…o/kibana into chore/management-page-conversions

thomheymann

LGTM!

kibanamachine · 2021-06-29T18:38:38Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`security`	783.3KB	781.5KB	-1.7KB
`spaces`	279.8KB	279.1KB	-640.0B
total			-2.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`spaces`	42.3KB	42.9KB	+545.0B

History

💛 Build #134534 was flaky 5d50162
💚 Build #134183 succeeded 51b4925
💚 Build #133765 succeeded e98251c
💚 Build #132656 succeeded ecf0354
💚 Build #132623 succeeded 1228521

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-06-29T18:41:31Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co>

legrego added 3 commits June 8, 2021 14:56

Convert security management pages to new layout

d00b4b0

Update translation files

9721106

Revert test code

fc61b66

legrego added release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.14.0 v8.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 9, 2021

legrego commented Jun 9, 2021

View reviewed changes

legrego marked this pull request as ready for review June 9, 2021 14:05

legrego requested a review from a team as a code owner June 9, 2021 14:05

legrego requested a review from cchaos June 9, 2021 14:05

cchaos reviewed Jun 10, 2021

View reviewed changes

legrego added 2 commits June 10, 2021 17:19

Merge branch 'master' of github.com:elastic/kibana into chore/managem…

7d0bcd7

…ent-page-conversions

address feedback for security plugins

49fbd78

spalger added v8.0.0 and removed v8.0 labels Jun 10, 2021

legrego added 4 commits June 14, 2021 10:22

Additional UI tweaks

368275f

Merge branch 'master' of github.com:elastic/kibana into chore/managem…

900e728

…ent-page-conversions

remove unused import

b173524

Update snapshot

ce65cae

cchaos approved these changes Jun 14, 2021

View reviewed changes

legrego requested a review from watson June 14, 2021 20:04

cchaos mentioned this pull request Jun 16, 2021

[Meta] Stack Management page conversions for new layout #101336

Closed

16 tasks

Merge branch 'master' into chore/management-page-conversions

1a27ba0

Merge branch 'master' into chore/management-page-conversions

687f567

Merge branch 'master' into chore/management-page-conversions

3b26ce4

Merge branch 'master' into chore/management-page-conversions

1228521

thomheymann reviewed Jun 21, 2021

View reviewed changes

legrego added 3 commits June 21, 2021 08:49

Fix create button inconsistency

3e79db6

Merge branch 'master' of github.com:elastic/kibana into chore/managem…

36e01b5

…ent-page-conversions

Merge branch 'chore/management-page-conversions' of github.com:legreg…

ecf0354

…o/kibana into chore/management-page-conversions

legrego requested a review from thomheymann June 23, 2021 11:13

Merge branch 'master' into chore/management-page-conversions

e98251c

thomheymann reviewed Jun 24, 2021

View reviewed changes

legrego added 3 commits June 24, 2021 13:13

Merge branch 'master' of github.com:elastic/kibana into chore/managem…

c92adaa

…ent-page-conversions

Change button icons to outlined versions

e8061fc

Merge branch 'chore/management-page-conversions' of github.com:legreg…

51b4925

…o/kibana into chore/management-page-conversions

Merge branch 'master' into chore/management-page-conversions

5d50162

legrego requested a review from thomheymann June 28, 2021 16:55

legrego added 3 commits June 29, 2021 11:54

Merge branch 'master' of github.com:elastic/kibana into chore/managem…

264edde

…ent-page-conversions

Stop user action panels from growing

2fc8015

Merge branch 'chore/management-page-conversions' of github.com:legreg…

31a97ad

…o/kibana into chore/management-page-conversions

thomheymann approved these changes Jun 29, 2021

View reviewed changes

legrego enabled auto-merge (squash) June 29, 2021 16:36

legrego merged commit 6c172ea into elastic:master Jun 29, 2021

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 29, 2021

Convert security management pages to new layout (elastic#101660)

da184b9

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine mentioned this pull request Jun 29, 2021

[7.x] Convert security management pages to new layout (#101660) #103735

Merged

kibanamachine added a commit that referenced this pull request Jun 30, 2021

Convert security management pages to new layout (#101660) (#103735)

2b893e1

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co>

Conversation

legrego commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Users

Roles

Role mappings

API Keys

Spaces

Uh oh!

legrego Jun 9, 2021

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 9, 2021

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

legrego commented Jun 16, 2021

Uh oh!

legrego commented Jun 16, 2021

Uh oh!

legrego commented Jun 17, 2021

Uh oh!

legrego commented Jun 17, 2021

Uh oh!

legrego commented Jun 21, 2021

Uh oh!

thomheymann Jun 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

legrego Jun 21, 2021

Choose a reason for hiding this comment

Uh oh!

cchaos Jun 23, 2021

Choose a reason for hiding this comment

Uh oh!

thomheymann Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

cchaos Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

legrego commented Jun 23, 2021

Uh oh!

thomheymann left a comment

Choose a reason for hiding this comment

Uh oh!

thomheymann Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

legrego commented Jun 24, 2021

Uh oh!

legrego commented Jun 28, 2021

Uh oh!

thomheymann left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 29, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Jun 29, 2021

💚 Backport successful

Uh oh!

legrego commented Jun 8, 2021 •

edited

Loading

thomheymann Jun 21, 2021 •

edited

Loading