Skip to content

[Security Solution]Memory protection configuration card for policies integration.#101365

Merged
academo merged 34 commits intoelastic:masterfrom
academo:feature/memory_protection_policy_integration-1213
Jul 19, 2021
Merged

[Security Solution]Memory protection configuration card for policies integration.#101365
academo merged 34 commits intoelastic:masterfrom
academo:feature/memory_protection_policy_integration-1213

Conversation

@academo
Copy link
Copy Markdown
Contributor

@academo academo commented Jun 4, 2021

Summary

Adds the Memory Protection configuration card in the policies detail view.

image

The current implementation is a clone of the malware protection card.

Missing on this PR:

  • Data migrations for the new "memory" key in policy details
  • Put this functionality behind a feature flag

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@academo academo added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 labels Jun 4, 2021
@academo academo requested review from parkiino and paul-tavares June 4, 2021 10:14
@parkiino
Copy link
Copy Markdown
Contributor

parkiino commented Jun 4, 2021

checked out the branch! looking good so far :D

@academo academo marked this pull request as ready for review June 28, 2021 07:12
@academo academo requested a review from a team as a code owner June 28, 2021 07:12
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@academo academo added the release_note:feature Makes this part of the condensed release notes label Jun 28, 2021
@academo academo changed the title Memory protection configuration card for policies integration. [Security Solution]Memory protection configuration card for policies integration. Jun 29, 2021
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes for adding the migration LGTM, though I'll let others take a more thorough look into the workings.

@academo academo added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 1, 2021
Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A some comment. Let me know if you have any questions

@academo academo requested a review from a team as a code owner July 16, 2021 13:03
@dasansol92
Copy link
Copy Markdown
Contributor

[This comment is a test] Testing slack notifications

Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments, but am OK with you proceeding to merge.

@academo academo enabled auto-merge (squash) July 19, 2021 14:42
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2208 2209 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.3MB 6.3MB +3.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 20, 2021
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (187 commits)
  Space management page UX improvements (elastic#100448)
  [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252)
  Update dependency @elastic/charts to v33 (master) (elastic#105633)
  [Observability RAC] Improve alerts table columns (elastic#105446)
  Introduce `preboot` lifecycle stage (elastic#103636)
  [Security Solution] Invalid kql query timeline refresh bug (elastic#105525)
  skip flaky suite (elastic#106121)
  [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118)
  docs: APM RUM Source map API (elastic#105332)
  [CTI] Adds indicator match rule improvements (elastic#97310)
  [Security Solution] update text for Isolation action submissions (elastic#105956)
  EP Meta Telemetry Perf (elastic#104396)
  [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784)
  Remove beta admonitions for Fleet docs (elastic#106010)
  [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970)
  Parameterize migration test for kibana version (elastic#105417)
  [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626)
  [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007)
  [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027)
  [Security Solution]Memory protection configuration card for policies integration. (elastic#101365)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/management/report_listing.tsx
kibanamachine added a commit that referenced this pull request Jul 20, 2021
…integration. (#101365) (#106129)

Co-authored-by: Esteban Beltran <academo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:feature Makes this part of the condensed release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants