[Security solution][Endpoint] Add back button when to the event filters list#101280
Merged
dasansol92 merged 4 commits intoelastic:masterfrom Jun 9, 2021
Conversation
…rnal app button to be used as generic component
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
paul-tavares
approved these changes
Jun 4, 2021
Contributor
paul-tavares
left a comment
There was a problem hiding this comment.
NICE! 🔥
We probably should also add a test case to the page view to ensure this is covered. Or maybe a end-to-end FTR test case to ensure we "touch" the fleet page.
Contributor
Author
|
@paul-tavares added unit tests |
Contributor
Author
|
@elasticmachine merge upstream |
…ers_tab_to_the_integration_tab-101264
ashokaditya
approved these changes
Jun 8, 2021
Member
ashokaditya
left a comment
There was a problem hiding this comment.
🚀 LGTM. I only have nitpicks. Feel free to ignore if not relevant 😄
| }); | ||
| }); | ||
|
|
||
| describe('and the back button is present', () => { |
Member
There was a problem hiding this comment.
nitpick: Maybe just call this Back button since now it looks similar to the test description name below.
Contributor
Author
There was a problem hiding this comment.
I'm going to merge this before having more out of date check errors and will do this change in next pr :)
| if (routeState && routeState.onBackButtonNavigateTo) { | ||
| return <BackToExternalAppButton {...routeState} />; | ||
| } | ||
| return null; |
Member
There was a problem hiding this comment.
nitpick: does headerComponent expect a null instead of undefined?
Contributor
Author
There was a problem hiding this comment.
Yes, it's an optional component, so null works in this case
Contributor
Author
|
@elasticmachine merge upstream |
…ers_tab_to_the_integration_tab-101264
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 9, 2021
…rs list (elastic#101280) * Add back button when to the event filters list. Isolated back to external app button to be used as generic component * Adds unit tests for back button Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2021
…rs list (#101280) (#101727) * Add back button when to the event filters list. Isolated back to external app button to be used as generic component * Adds unit tests for back button Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: David Sánchez <davidsansol92@gmail.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 9, 2021
* master: clarify which parts of TM are experimental (elastic#101757) Add sh scripts with _bulk_action route usage examples (elastic#101736) [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709) Use KIBANA_DOCS in doc link service (elastic#101667) [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387) Address design issues in Discover/Graph (elastic#101584) Optimize performance for document table (elastic#101715) Change file data visualizer links to point to new location in home application (elastic#101393) [Fleet] Tighten policy permissions, take II (elastic#97366) [ML] Add debounce to the severity control update (elastic#101581) [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658) [APM] Add link-to/transaction route (elastic#101731) [Index Patterns] Runtime fields CRUD REST API (elastic#101164) [ILM] Refactor types and fix missing aria labels (elastic#101518) [Lens] New summary row feature for datatable (elastic#101075) Blocks save event filter with a white space name (elastic#101599) Improve security server types (elastic#101661) [APM] Replace side nav with tabs on Settings page (elastic#101460) [APM] Only register items in side nav if user has permissions to see app (elastic#101707) [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add back button when to the event filters list.
Also, isolated back to external app button to be used as generic component
For maintainers