[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB viz with no timefield defined#100864
Merged
alexwizp merged 1 commit intoelastic:masterfrom May 28, 2021
Merged
[TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB viz with no timefield defined#100864alexwizp merged 1 commit intoelastic:masterfrom
alexwizp merged 1 commit intoelastic:masterfrom
Conversation
alexwizp
commented
May 28, 2021
| ] as IndexPattern[]; | ||
|
|
||
| const value = await fetchIndexPattern('indexTitle', indexPatternsService, { | ||
| fetchKibabaIndexForStringIndexes: true, |
alexwizp
commented
May 28, 2021
| }); | ||
| }, [fetchedIndex]); | ||
|
|
||
| useEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
this effect was moved into parent component to reuse fetchedIndex for field selector placeholder
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
approved these changes
May 28, 2021
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Changes LGTM, solves the problem. I tested it locally using Chrome
Contributor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 28, 2021
Contributor
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
May 28, 2021
Closes: elastic#100778 # Conflicts: # src/plugins/vis_type_timeseries/public/application/components/index_pattern.js
kibanamachine
added a commit
that referenced
this pull request
May 28, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 28, 2021
* master: (77 commits) [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015) [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809) updating the saved objects test to include more saved object types (elastic#100828) [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789) Fixing ES archive mapping failure (elastic#100835) Fix bug with Observability > APM header navigation (elastic#100845) [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668) [Actions] Taking space id into account when creating email footer link (elastic#100734) Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823) [Security Solution] Improve find rule and find rule status route performance (elastic#99678) [DOCS] Adds video to introduction (elastic#100906) [Fleet] Improve combo box for fleet settings (elastic#100603) [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813) [DOCS] Adds Lens video (elastic#100898) [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765) chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810) [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718) [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864) [Lens] Adds dynamic table cell coloring (elastic#95217) [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853) ...
alexwizp
added a commit
that referenced
this pull request
May 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #100778
Summary
This PR related to #100778 and fix the following case #100778 (comment)
Steps to reproduce:
Install
flightsdata setImport the following SO so.ndjson.zip
Open TSVB visualization which was imported in step 2