Skip to content

[Lens] fix error when adding a new layer#100766

Merged
mbondyra merged 2 commits intoelastic:masterfrom
mbondyra:lens/fix_add_layer_console.log
May 27, 2021
Merged

[Lens] fix error when adding a new layer#100766
mbondyra merged 2 commits intoelastic:masterfrom
mbondyra:lens/fix_add_layer_console.log

Conversation

@mbondyra
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra commented May 27, 2021

Summary

WIth this configuration, you get this on the console:
Screenshot 2021-05-27 at 12 08 26
Screenshot 2021-05-27 at 12 09 08

@mbondyra mbondyra requested a review from a team May 27, 2021 12:36
@mbondyra mbondyra mentioned this pull request May 27, 2021
Merged
@mbondyra mbondyra added Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.14.0 v8.0.0 labels May 27, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 27, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Copy Markdown
Contributor

flash1293 commented May 27, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 27, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +112.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes May 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to reproduce this problem (it might be tied to some special timing) but I can definitely see this could happen and we should definitely check for it like you. LGTM

@mbondyra mbondyra merged commit 48f7a47 into elastic:master May 27, 2021
@mbondyra mbondyra mentioned this pull request May 27, 2021
Merged
mbondyra added a commit to mbondyra/kibana that referenced this pull request May 27, 2021
@mbondyra @kibanamachine
[Lens] fix error when adding a new layer (elastic#100766)
b28254b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mbondyra added a commit that referenced this pull request May 28, 2021
@mbondyra @kibanamachine
[Lens] fix error when adding a new layer (#100766) (#100834)
8a60908 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

No one assigned

Labels

Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbondyra @elasticmachine @flash1293 @kibanamachine