Skip to content

[Fleet] Add clear button to search input bars#100476

Merged
Zacqary merged 1 commit intoelastic:masterfrom
Zacqary:98734-clearable-searchbar
May 24, 2021
Merged

[Fleet] Add clear button to search input bars#100476
Zacqary merged 1 commit intoelastic:masterfrom
Zacqary:98734-clearable-searchbar

Conversation

@Zacqary
Copy link
Copy Markdown
Contributor

@Zacqary Zacqary commented May 24, 2021

Summary

Closes #98734

Adds the isClearable flag to search bars throughout the Fleet app.

Screen Shot 2021-05-24 at 11 52 58 AM

@Zacqary Zacqary added release_note:fix v8.0.0 Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 labels May 24, 2021
@Zacqary Zacqary self-assigned this May 24, 2021
@Zacqary Zacqary requested a review from a team as a code owner May 24, 2021 16:55
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Feature:Fleet)

Copy link
Copy Markdown
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and quick, thanks!

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 731.3KB 731.3KB +15.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Zacqary

@Zacqary Zacqary added the auto-backport Deprecated - use backport:version if exact versions are needed label May 24, 2021
@Zacqary Zacqary merged commit 676d40e into elastic:master May 24, 2021
@Zacqary Zacqary deleted the 98734-clearable-searchbar branch May 24, 2021 22:30
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 24, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Fleet Fleet team's agent central management project release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Agents list - Table search/filter doesn't show a clear option

4 participants