-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Controls] Move control group diffing from Dashboard to Control plugin #174703
Copy link
Copy link
Closed
Labels
Feature:DashboardDashboard related featuresDashboard related featuresFeature:Input ControlInput controls visualizationInput controls visualizationProject:ControlsTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//impact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.loe:largeLarge Level of EffortLarge Level of Effort
Metadata
Metadata
Assignees
Labels
Feature:DashboardDashboard related featuresDashboard related featuresFeature:Input ControlInput controls visualizationInput controls visualizationProject:ControlsTeam:PresentationPresentation Team for Dashboard, Input Controls, and Canvas t//Presentation Team for Dashboard, Input Controls, and Canvas t//impact:highAddressing this issue will have a high level of impact on the quality/strength of our product.Addressing this issue will have a high level of impact on the quality/strength of our product.loe:largeLarge Level of EffortLarge Level of Effort
Type
Fields
Give feedbackNo fields configured for issues without a type.
Describe the feature:
Currently, the Dashboard handles the diffing of all panels + the control group to determine whether or not there are any unsaved changes - however, as part of the Embeddable Refactor work, this will no longer be the case. Instead, the control group (and the dashboard children/panels) will handle their own diffing and simply communicate to Dashboard whether or not they have unsaved changes (and, on request, what these unsaved changes are for session storage management).
Describe a specific use case for the feature:
This is related to the Embeddable Refactor work, but it is also necessary for the Apply button because, in order for that to work, the control group needs to know when it has unsaved changes so that we can enable/disable the buttons accordingly.