Skip to content

Commit 4b2aeae

Browse files
Return EUI CSS to Shareable Runtime (#72990)
* Add Canvas Styles * Tree-shaking in EUI omits CSS in the runtime Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent faba7fe commit 4b2aeae

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

x-pack/plugins/canvas/shareable_runtime/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ There are a number of options for the build script:
207207

208208
### Prerequisite
209209

210-
Before testing or running this PR locally, you **must** run `node scripts/runtime` from `/canvas` _after_ `yarn kbn bootstrap` and _before_ starting Kibana. It is only built automatically when Kibana is built to avoid slowing down other development activities.
210+
Before testing or running this PR locally, you **must** run `node scripts/shareable_runtime` from `/canvas` _after_ `yarn kbn bootstrap` and _before_ starting Kibana. It is only built automatically when Kibana is built to avoid slowing down other development activities.
211211

212212
### Webpack Dev Server
213213

x-pack/plugins/canvas/shareable_runtime/webpack.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ module.exports = {
5555
options: {
5656
presets: [require.resolve('@kbn/babel-preset/webpack_preset')],
5757
},
58-
sideEffects: false,
5958
},
6059
{
6160
test: /\.tsx?$/,
@@ -92,6 +91,7 @@ module.exports = {
9291
},
9392
},
9493
],
94+
sideEffects: true,
9595
},
9696
{
9797
test: /\.module\.s(a|c)ss$/,

0 commit comments

Comments
 (0)