Skip to content

Commit 47897a2

Browse files
Spencerspalgerelasticmachine
authored
[7.x] Remove legacy optimizer (#73154) (#74966)
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent 52dae0b commit 47897a2

303 files changed

Lines changed: 23633 additions & 30283 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintignore

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,12 @@ target
1818

1919
# plugin overrides
2020
/src/core/lib/kbn_internal_native_observable
21-
/src/legacy/core_plugins/console/public/tests/webpackShims
22-
/src/legacy/core_plugins/console/public/webpackShims
2321
/src/legacy/plugin_discovery/plugin_pack/__tests__/fixtures/plugins/broken
2422
/src/legacy/ui/public/flot-charts
25-
/src/legacy/ui/public/utils/decode_geo_hash.js
2623
/src/plugins/data/common/es_query/kuery/ast/_generated_/**
2724
/src/plugins/vis_type_timelion/public/_generated_/**
28-
/src/plugins/vis_type_timelion/public/webpackShims/jquery.flot.*
29-
/src/plugins/timelion/public/webpackShims/jquery.flot.*
25+
/src/plugins/vis_type_timelion/public/flot/jquery.flot.*
26+
/src/plugins/timelion/public/flot/jquery.flot.*
3027
/x-pack/legacy/plugins/**/__tests__/fixtures/**
3128
/x-pack/plugins/apm/e2e/**/snapshots.js
3229
/x-pack/plugins/apm/e2e/tmp/*

.eslintrc.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ module.exports = {
404404
},
405405
{
406406
target: ['(src|x-pack)/plugins/*/public/**/*'],
407-
from: ['ui/**/*', 'uiExports/**/*'],
407+
from: ['ui/**/*'],
408408
errorMessage: 'Plugins cannot import legacy UI code.',
409409
},
410410
{
@@ -461,14 +461,13 @@ module.exports = {
461461
{
462462
files: [
463463
'**/public/**/*.js',
464-
'**/webpackShims/**/*.js',
465464
'packages/kbn-ui-framework/doc_site/src/**/*.js',
466465
'src/fixtures/**/*.js', // TODO: this directory needs to be more obviously "public" (or go away)
467466
],
468467
settings: {
469468
// instructs import/no-extraneous-dependencies to treat certain modules
470469
// as core modules, even if they aren't listed in package.json
471-
'import/core-modules': ['plugins', 'legacy/ui', 'uiExports'],
470+
'import/core-modules': ['plugins', 'legacy/ui'],
472471

473472
'import/resolver': {
474473
'@kbn/eslint-import-resolver-kibana': {
@@ -609,7 +608,6 @@ module.exports = {
609608
{
610609
files: [
611610
'.eslintrc.js',
612-
'**/webpackShims/**/*.js',
613611
'packages/kbn-plugin-generator/**/*.js',
614612
'packages/kbn-eslint-import-resolver-kibana/**/*.js',
615613
'packages/kbn-eslint-plugin-eslint/**/*',

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ out an open PR:
3232

3333
- [CONTRIBUTING.md](CONTRIBUTING.md) will help you get Kibana up and running.
3434
- If you would like to contribute code, please follow our [STYLEGUIDE.md](STYLEGUIDE.md).
35-
- Learn more about our UI code with [UI_SYSTEMS.md](src/legacy/ui/public/UI_SYSTEMS.md).
3635
- For all other questions, check out the [FAQ.md](FAQ.md) and
3736
[wiki](https://github.com/elastic/kibana/wiki).
3837

STYLEGUIDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ Do not use setters, they cause more problems than they can solve.
593593
594594
When writing a new component, create a sibling SASS file of the same name and import directly into the **top** of the JS/TS component file. Doing so ensures the styles are never separated or lost on import and allows for better modularization (smaller individual plugin asset footprint).
595595
596-
All SASS (.scss) files will automatically build with the [EUI](https://elastic.github.io/eui/#/guidelines/sass) & Kibana invisibles (SASS variables, mixins, functions) from the [`globals_[theme].scss` file](src/legacy/ui/public/styles/_globals_v7light.scss).
596+
All SASS (.scss) files will automatically build with the [EUI](https://elastic.github.io/eui/#/guidelines/sass) & Kibana invisibles (SASS variables, mixins, functions) from the [`globals_[theme].scss` file](src/core/public/core_app/styles/_globals_v7light.scss).
597597
598598
While the styles for this component will only be loaded if the component exists on the page,
599599
the styles **will** be global and so it is recommended to use a three letter prefix on your

docs/setup/install/deb.asciidoc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,6 @@ locations for a Debian-based system:
214214
| /var/log/kibana
215215
| path.logs
216216

217-
| optimize
218-
| Transpiled source code. Certain administrative actions (e.g. plugin install)
219-
result in the source code being retranspiled on the fly.
220-
| /usr/share/kibana/optimize
221-
d|
222-
223217
| plugins
224218
| Plugin files location. Each plugin will be contained in a subdirectory.
225219
| /usr/share/kibana/plugins

docs/setup/install/rpm.asciidoc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -206,12 +206,6 @@ locations for an RPM-based system:
206206
| /var/log/kibana
207207
| path.logs
208208

209-
| optimize
210-
| Transpiled source code. Certain administrative actions (e.g. plugin install)
211-
result in the source code being retranspiled on the fly.
212-
| /usr/share/kibana/optimize
213-
d|
214-
215209
| plugins
216210
| Plugin files location. Each plugin will be contained in a subdirectory.
217211
| /usr/share/kibana/plugins

docs/setup/install/targz.asciidoc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,6 @@ important data later on.
149149
| $KIBANA_HOME\data
150150
d|
151151

152-
| optimize
153-
| Transpiled source code. Certain administrative actions (e.g. plugin install)
154-
result in the source code being retranspiled on the fly.
155-
| $KIBANA_HOME\optimize
156-
d|
157-
158152
| plugins
159153
| Plugin files location. Each plugin will be contained in a subdirectory.
160154
| $KIBANA_HOME\plugins

docs/setup/install/windows.asciidoc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,6 @@ important data later on.
9696
| $KIBANA_HOME\data
9797
d|
9898

99-
| optimize
100-
| Transpiled source code. Certain administrative actions (e.g. plugin install)
101-
result in the source code being retranspiled on the fly.
102-
| $KIBANA_HOME\optimize
103-
d|
104-
10599
| plugins
106100
| Plugin files location. Each plugin will be contained in a subdirectory.
107101
| $KIBANA_HOME\plugins

package.json

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@
115115
},
116116
"dependencies": {
117117
"@babel/core": "^7.11.1",
118-
"@babel/plugin-transform-modules-commonjs": "^7.10.4",
119118
"@babel/register": "^7.10.5",
120119
"@elastic/apm-rum": "^5.4.0",
121120
"@elastic/charts": "19.8.1",
@@ -151,20 +150,16 @@
151150
"angular-route": "^1.8.0",
152151
"angular-sanitize": "^1.8.0",
153152
"angular-sortable-view": "^0.0.17",
154-
"autoprefixer": "^9.7.4",
155-
"babel-loader": "^8.0.6",
156153
"bluebird": "3.5.5",
157154
"boom": "^7.2.0",
158155
"brace": "0.11.1",
159-
"cache-loader": "^4.1.0",
160156
"chalk": "^2.4.2",
161157
"check-disk-space": "^2.1.0",
162158
"chokidar": "3.2.1",
163159
"color": "1.0.3",
164160
"commander": "3.0.2",
165161
"compare-versions": "3.5.1",
166162
"core-js": "^3.6.4",
167-
"css-loader": "^3.4.2",
168163
"d3": "3.5.17",
169164
"d3-cloud": "1.2.5",
170165
"deep-freeze-strict": "^1.1.1",
@@ -176,7 +171,6 @@
176171
"execa": "^4.0.2",
177172
"expiry-js": "0.1.7",
178173
"fast-deep-equal": "^3.1.1",
179-
"file-loader": "4.2.0",
180174
"font-awesome": "4.7.0",
181175
"fp-ts": "^2.3.1",
182176
"getos": "^3.1.0",
@@ -208,11 +202,9 @@
208202
"leaflet-vega": "^0.8.6",
209203
"leaflet.heat": "0.2.0",
210204
"less": "npm:@elastic/less@2.7.3-kibana",
211-
"less-loader": "5.0.0",
212205
"lodash": "^4.17.15",
213206
"lru-cache": "4.1.5",
214207
"markdown-it": "^10.0.0",
215-
"mini-css-extract-plugin": "0.8.0",
216208
"minimatch": "^3.0.4",
217209
"moment": "^2.24.0",
218210
"moment-timezone": "^0.5.27",
@@ -224,12 +216,9 @@
224216
"opn": "^5.5.0",
225217
"oppsy": "^2.0.0",
226218
"pegjs": "0.10.0",
227-
"postcss-loader": "^3.0.0",
228219
"prop-types": "15.6.0",
229220
"proxy-from-env": "1.0.0",
230-
"pug": "^2.0.4",
231221
"query-string": "5.1.1",
232-
"raw-loader": "3.1.0",
233222
"re2": "^1.15.4",
234223
"react": "^16.12.0",
235224
"react-color": "^2.13.8",
@@ -255,30 +244,22 @@
255244
"resize-observer-polyfill": "^1.5.0",
256245
"rison-node": "1.0.2",
257246
"rxjs": "^6.5.5",
258-
"script-loader": "0.7.2",
259247
"seedrandom": "^3.0.5",
260248
"semver": "^5.5.0",
261-
"style-loader": "^1.1.3",
262249
"symbol-observable": "^1.2.0",
263250
"tar": "4.4.13",
264-
"terser-webpack-plugin": "^2.3.4",
265-
"thread-loader": "^2.1.3",
266251
"tinygradient": "0.4.3",
267252
"tinymath": "1.2.1",
268253
"topojson-client": "3.0.0",
269254
"tslib": "^2.0.0",
270255
"type-detect": "^4.0.8",
271256
"ui-select": "0.19.8",
272-
"url-loader": "2.2.0",
273257
"uuid": "3.3.2",
274-
"val-loader": "^1.1.1",
275258
"vega": "^5.13.0",
276259
"vega-lite": "^4.13.1",
277260
"vega-schema-url-parser": "^1.1.0",
278261
"vega-tooltip": "^0.12.0",
279262
"vision": "^5.3.3",
280-
"webpack": "^4.41.5",
281-
"webpack-merge": "4.2.2",
282263
"whatwg-fetch": "^3.0.0",
283264
"yauzl": "2.10.0"
284265
},
@@ -445,8 +426,6 @@
445426
"has-ansi": "^3.0.0",
446427
"iedriver": "^3.14.2",
447428
"intl-messageformat-parser": "^1.4.0",
448-
"is-path-inside": "^2.1.0",
449-
"istanbul-instrumenter-loader": "3.0.1",
450429
"jest": "^25.5.4",
451430
"jest-canvas-mock": "^2.2.0",
452431
"jest-circus": "^25.5.4",
@@ -467,14 +446,12 @@
467446
"murmurhash3js": "3.0.1",
468447
"mutation-observer": "^1.0.3",
469448
"nock": "12.0.3",
470-
"node-sass": "^4.13.1",
471449
"normalize-path": "^3.0.0",
472450
"nyc": "^14.1.1",
473451
"pixelmatch": "^5.1.0",
474452
"pkg-up": "^2.0.0",
475453
"pngjs": "^3.4.0",
476454
"postcss": "^7.0.32",
477-
"postcss-url": "^8.0.0",
478455
"prettier": "^2.0.5",
479456
"proxyquire": "1.8.0",
480457
"react-popper-tooltip": "^2.10.1",

packages/eslint-config-kibana/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,6 @@
2929
"eslint-plugin-no-unsanitized": "^3.0.2",
3030
"eslint-plugin-prefer-object-spread": "^1.2.1",
3131
"eslint-plugin-react": "^7.17.0",
32-
"eslint-plugin-react-hooks": "^2.3.0"
32+
"eslint-plugin-react-hooks": "^4.0.4"
3333
}
3434
}

0 commit comments

Comments
 (0)