Skip to content

[Apache] Rename apache2.error.integration to apache.error.module#9822

Merged
herrBez merged 3 commits intoelastic:mainfrom
herrBez:main
May 9, 2024
Merged

[Apache] Rename apache2.error.integration to apache.error.module#9822
herrBez merged 3 commits intoelastic:mainfrom
herrBez:main

Conversation

@herrBez
Copy link
Copy Markdown
Contributor

@herrBez herrBez commented May 9, 2024 •
edited by shmsr
Loading

Proposed commit message

Rename apache2.error.integration to apache.error.module

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@herrBez herrBez added the bug Something isn't working, use only for issues label May 9, 2024
@herrBez herrBez requested a review from a team as a code owner May 9, 2024 07:17
@shmsr
Copy link
Copy Markdown
Member

shmsr commented May 9, 2024 •
edited
Loading

Shouldn't this be apache2.error.integration to apache.error.integration? Why module?

@herrBez
Copy link
Copy Markdown
Contributor Author

herrBez commented May 9, 2024 •
edited
Loading

Because the field in the apache.error dataset is apache.error.module. This field represents the Apache Module (https://httpd.apache.org/docs/2.4/mod/core.html#errorlogformat), it has nothing to do with Elastic integrations and should be the same of the Beats apache.error dataset):

https://github.com/elastic/integrations/blob/main/packages/apache/data_stream/error/elasticsearch/ingest_pipeline/default.yml#L21

Sorry for the overloaded terms :D. Hope it makes sense

@shmsr
Copy link
Copy Markdown
Member

shmsr commented May 9, 2024

@herrBez Makes sense. Thanks.

shmsr
shmsr approved these changes May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for someone else from my team as well to give a +1 on this.

@devamanv
Copy link
Copy Markdown
Contributor

devamanv commented May 9, 2024 •
edited
Loading

@herrBez LGTM. You will also have to update the package version in manifest.yml. This is needed for the CI checks to pass.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 9, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 9, 2024

💚 Build Succeeded

History

cc @herrBez

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented May 9, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

devamanv
devamanv approved these changes May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herrBez herrBez merged commit f398bad into elastic:main May 9, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 9, 2024

Package apache - 1.17.2 containing this change is available at https://epr.elastic.co/search?package=apache

@andrewkroh andrewkroh added the Integration:apache Apache HTTP Server label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shmsr shmsr shmsr approved these changes

+1 more reviewer

@devamanv devamanv devamanv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@herrBez herrBez

Labels

bug Something isn't working, use only for issues Integration:apache Apache HTTP Server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@herrBez @shmsr @devamanv @elasticmachine @andrewkroh