Skip to content

filebeat/module/apache: Rename the field apache2.module.error to apache.module.error#39481

Merged
herrBez merged 8 commits intomainfrom
herrBez-patch-3
May 28, 2024
Merged

filebeat/module/apache: Rename the field apache2.module.error to apache.module.error#39481
herrBez merged 8 commits intomainfrom
herrBez-patch-3

Conversation

@herrBez
Copy link
Copy Markdown
Contributor

@herrBez herrBez commented May 9, 2024 •
edited by devamanv
Loading

Proposed commit message

Rename field apache2.module.error to apache.module.error in the Dashboard

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

image

The original saved search uses apache2.error.module, while the correct field apache.error.module (added by me) shows that it is actually populated with a meaningful value.

Logs

@herrBez herrBez requested a review from a team as a code owner May 9, 2024 06:44
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 9, 2024
@botelastic
Copy link
Copy Markdown

botelastic bot commented May 9, 2024

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 9, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @herrBez? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned herrBez May 9, 2024
@shmsr
Copy link
Copy Markdown
Member

shmsr commented May 9, 2024

Nice find. Can you also open a PR for the integrations repo? See: https://github.com/search?q=repo%3Aelastic%2Fintegrations+path%3A%2F%5Epackages%5C%2Fapache%5C%2Fkibana%5C%2F%2F+apache2&type=code

@shmsr shmsr changed the title Rename apache2.module.error into apache.module.error in the Apache error integration filebeat/module/apache: Rename column from apache2.module.error to apache.module.error May 9, 2024
@shmsr
Copy link
Copy Markdown
Member

shmsr commented May 9, 2024

Please add an entry to the changelog.

@herrBez
Copy link
Copy Markdown
Contributor Author

herrBez commented May 9, 2024 •
edited
Loading

Thank you. I think I addressed both points now :) . I am on it for the integration's PR

shmsr
shmsr requested changes May 9, 2024
View reviewed changes
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 9, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-09T07:24:58.495+0000

  • Duration: 159 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 8428
Skipped 773
Total 9201

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shmsr
Copy link
Copy Markdown
Member

shmsr commented May 9, 2024

Changes LGTM. However, I would like another member of my team to review this as well before we merge.

@shmsr shmsr changed the title filebeat/module/apache: Rename column from apache2.module.error to apache.module.error filebeat/module/apache: Rename the field apache2.module.error to apache.module.error May 9, 2024
@herrBez herrBez mentioned this pull request May 9, 2024
Merged
4 tasks
@herrBez @shmsr
Update CHANGELOG.next.asciidoc
5d3e16e 
Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
devamanv
devamanv approved these changes May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herrBez herrBez requested a review from shmsr May 10, 2024 12:54
@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented May 24, 2024

@shmsr @devamanv : I think this can be merged in beats as well?

@herrBez
Copy link
Copy Markdown
Contributor Author

herrBez commented May 24, 2024 •
edited
Loading

I see some failures in the build, but I hardly believe they are related with the change introduced here:
https://github.com/elastic/beats/pull/39481/checks?check_run_id=25345121364 .

@shmsr
Copy link
Copy Markdown
Member

shmsr commented May 28, 2024

@herrBez CI is passing. Let's merge?

@herrBez herrBez merged commit dff238b into main May 28, 2024
@herrBez herrBez deleted the herrBez-patch-3 branch May 28, 2024 08:04
@herrBez
Copy link
Copy Markdown
Contributor Author

herrBez commented May 28, 2024

Done. Thank you for the help and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shmsr shmsr shmsr approved these changes

+1 more reviewer

@devamanv devamanv devamanv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@herrBez herrBez

Labels

needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@herrBez @shmsr @elasticmachine @ishleenk17 @devamanv