Skip to content

[System] Add global filter in dashboard for System#9573

Merged
milan-elastic merged 5 commits intoelastic:mainfrom
milan-elastic:add-system-filters
Apr 23, 2024
Merged

[System] Add global filter in dashboard for System#9573
milan-elastic merged 5 commits intoelastic:mainfrom
milan-elastic:add-system-filters

Conversation

@milan-elastic
Copy link
Copy Markdown
Contributor

@milan-elastic milan-elastic commented Apr 12, 2024 •
edited
Loading

Proposed commit message

Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

System Windows Security User Logons

Before:

System Windows Security User Logons - Before

After:
System Windows Security User Logons - After

System Windows Security Group Management Events Before:

System Windows Security Group Management Events - Before

After:

System Windows Security Group Management Events - After

System Windows Security Failed and Blocked Accounts Before:

System Windows Security Failed and Blocked Accounts - Before

After:

System Windows Security Failed and Blocked Accounts - After

Metrics System Overview Before:

Metrics System Overview - Before

After:

Metrics System Overview - After

Metrics System Host overview Before:

Metrics System Host overview - Before

After:

Metrics System Host overview - After

User Management Events Before:

User Management Events - Before

After:

User Management Events - after

Syslog dashboard Before:

Syslog dashboard - Before

After:

Syslog dashboard - After

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 12, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@milan-elastic milan-elastic marked this pull request as ready for review April 12, 2024 06:24
@milan-elastic milan-elastic requested review from a team as code owners April 12, 2024 06:24
@milan-elastic milan-elastic mentioned this pull request Apr 12, 2024
Closed
58 tasks
@shmsr shmsr added the enhancement New feature or request label Apr 12, 2024
harnish-crest-data
harnish-crest-data approved these changes Apr 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tommyers-elastic
Copy link
Copy Markdown
Contributor

tommyers-elastic commented Apr 15, 2024

thanks for this! these diffs are impossible to read - would it be possible to show before/after screenshots in the PR description so a reviewer can visually confirm the changes look good? thanks !

@lalit-satapathy
Copy link
Copy Markdown
Contributor

lalit-satapathy commented Apr 15, 2024

thanks for this! these diffs are impossible to read - would it be possible to show before/after screenshots in the PR description so a reviewer can visually confirm the changes look good? thanks !

Agree, all visualisation changes can have a before vs. after.

@milan-elastic
Copy link
Copy Markdown
Contributor Author

milan-elastic commented Apr 18, 2024

thanks for this! these diffs are impossible to read - would it be possible to show before/after screenshots in the PR description so a reviewer can visually confirm the changes look good? thanks !

@tommyers-elastic I have populated the screenshots and updated them in description.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 22, 2024

💚 Build Succeeded

History

cc @milan-elastic

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Apr 22, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ishleenk17
Copy link
Copy Markdown
Member

ishleenk17 commented Apr 23, 2024

@milan-elastic : Before and after of the Windows dashboards look the same?
What's the change there?
Also, why are we also filtering by provider name in Windows dashboards?

@milan-elastic
Copy link
Copy Markdown
Contributor Author

milan-elastic commented Apr 23, 2024

@milan-elastic : Before and after of the Windows dashboards look the same? What's the change there? Also, why are we also filtering by provider name in Windows dashboards?

For the windows dashboards, we have removed the panel level filters as those are not needed anymore because there is already global level filter on dashboard level.
Regarding the provider name filter in windows dashboard, it was already there since beginning!

@milan-elastic
Copy link
Copy Markdown
Contributor Author

milan-elastic commented Apr 23, 2024

Can someone help me with a code owner review from @elastic/elastic-agent-data-plane , @elastic/kibana-visualizations team for this PR?

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] label Apr 23, 2024
@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Apr 23, 2024

@andresrc I don't think Data Plane team review should be necessary as this is now owned by your team directly.
I can give my +1 but I think we should change the codeowner for the kibana dashboard in addition. WDYT?

@lalit-satapathy
Copy link
Copy Markdown
Contributor

lalit-satapathy commented Apr 23, 2024

@andresrc I don't think Data Plane team review should be necessary as this is now owned by your team directly. I can give my +1 but I think we should change the codeowner for the kibana dashboard in addition. WDYT?

I agree, historically the system package kibana folder changes went to both data plane and Kibana team. That can be updated in the codeowner.

@pierrehilbert
Copy link
Copy Markdown
Contributor

pierrehilbert commented Apr 23, 2024

I'm approving to unblock you.
@lalit-satapathy could you please open a PR (that I will approve) to update the codeowners?

tommyers-elastic
tommyers-elastic approved these changes Apr 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything LGTM - except for one thing, the table at the bottom of the 'User Management Events' dashboard seems to have lost its column headings.

@milan-elastic
Copy link
Copy Markdown
Contributor Author

milan-elastic commented Apr 23, 2024

everything LGTM - except for one thing, the table at the bottom of the 'User Management Events' dashboard seems to have lost its column headings.

I see, it was just a scrolling issue in the screenshot, I have updated the screenshot with column header now!

@milan-elastic milan-elastic merged commit b64a068 into elastic:main Apr 23, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 23, 2024

Package system - 1.55.0 containing this change is available at https://epr.elastic.co/search?package=system

gizas pushed a commit that referenced this pull request Apr 26, 2024
@milan-elastic @gizas
[System] Add global filter in dashboard for System (#9573)
6e50efb 
* add global filter in dashboard

* update changelog pr link

* resolve panel filter issue

* minor change in filter

* update the changelog.yml
@lalit-satapathy lalit-satapathy mentioned this pull request Apr 29, 2024
Merged
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@milan-elastic @gizas
[System] Add global filter in dashboard for System (#9573)
50dd376 
* add global filter in dashboard

* update changelog pr link

* resolve panel filter issue

* minor change in filter

* update the changelog.yml
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@milan-elastic @gizas
[System] Add global filter in dashboard for System (#9573)
3d8a16f 
* add global filter in dashboard

* update changelog pr link

* resolve panel filter issue

* minor change in filter

* update the changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@shmsr shmsr shmsr approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

@drewdaemon drewdaemon Awaiting requested review from drewdaemon

+1 more reviewer

@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@milan-elastic milan-elastic

Labels

enhancement New feature or request Integration:system System Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@milan-elastic @elasticmachine @tommyers-elastic @lalit-satapathy @ishleenk17 @pierrehilbert @shmsr @harnish-crest-data