[aws_logs] Add custom settings variable#9512
Merged
andrewkroh merged 2 commits intoelastic:mainfrom Apr 24, 2024
andrewkroh:aws_logs/feature/custom-input-variable
Merged
[aws_logs] Add custom settings variable#9512andrewkroh merged 2 commits intoelastic:mainfrom andrewkroh:aws_logs/feature/custom-input-variable
andrewkroh merged 2 commits intoelastic:mainfrom
andrewkroh:aws_logs/feature/custom-input-variable
Conversation
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
💚 Build Succeeded
|
|
0.0% Duplication on New Code
Member
Author
|
@elastic/obs-ds-hosted-services, could you please take a look at this PR. |
kaiyan-sheng
approved these changes
Apr 24, 2024
kaiyan-sheng
left a comment
There was a problem hiding this comment.
It looks good to me. Do we need to give an example on hwo to use the custom setting?
Member
Author
|
I don't feel a strong need to include a default value containing commented out examples. The linked documentation has plenty. |
|
Package aws_logs - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=aws_logs |
gizas
pushed a commit
that referenced
this pull request
Apr 26, 2024
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
qcorporation
pushed a commit
that referenced
this pull request
Feb 3, 2025
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
qcorporation
pushed a commit
that referenced
this pull request
Feb 4, 2025
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add a
customvariable to allow passing additional settings to the input.Closes #9509
Checklist
changelog.ymlfile.Related issues