[system] Add missing conditional checks to render preserve_original_event tag when toggled on#9426
[system] Add missing conditional checks to render preserve_original_event tag when toggled on#9426devamanv merged 5 commits intoelastic:mainfrom devamanv:system-winlog-tags
preserve_original_event tag when toggled on#9426Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
| {{#each tags as |tag|}} | ||
| - {{tag}} | ||
| {{/each}} | ||
| {{#if preserve_original_event}} | ||
| - preserve_original_event | ||
| {{/if}} | ||
| {{else}} | ||
| {{#if preserve_original_event}} | ||
| tags: | ||
| - preserve_original_event | ||
| {{/if}} |
There was a problem hiding this comment.
Tested this rendering logic on a handlebar playground
intxgo
left a comment
There was a problem hiding this comment.
LGTM, this code does what's been described in the linked issue
preserve_original_event tag when toggled on
|
💚 Build Succeeded
History
cc @devamanv |
|
Package system - 1.55.1 containing this change is available at https://epr.elastic.co/search?package=system |
…event` tag when toggled on (#9426)
…event` tag when toggled on (#9426)
…event` tag when toggled on (#9426)








Proposed commit message
The PR contains changes to make sure the
preserve_original_eventtag is rendered without having to add that manually. Complete details have been captured in the related issue. Affected datastreams areapplication,security, andsystem.Checklist
changelog.ymlfile.Author's Checklist
Following are some of the sanity checks that must be passed at all times:
How to test this PR locally
elastic-packageto the running Kibana instanceelastic-package install --zip system-1.54.1.zip1.54.1, there shouldn't be any errors. If you find any errors while upgrading, please report it by adding a comment to this PR.application,security, andsystemdatastream. The preserve_original_event should be rendered when toggled on, and all others tags should render if added in the advanced options at the time of adding the integration.Related issues
Screenshots