Merged
Conversation
francescayeye
approved these changes
Feb 22, 2024
drewdaemon
approved these changes
Feb 22, 2024
Contributor
drewdaemon
left a comment
There was a problem hiding this comment.
A few suggestions to consider for the dashboard
- There seems to be a floating icon (Grammerly?) captured in the screenshot
- Consider changing the metrics to the new Lens metric, stacked vertically. You could increase the width of the top chart to make up for lost horizontal space
- Adding panel titles would make it much easier to scan for the information I'm looking for. And/or you could add markdown panels in between the first and second row and second and third row with a larger title that describes both visualizations.
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
route53_public_logs |
13513.51 | 10869.57 | -2643.94 (-19.57%) | 💔 |
waf |
5747.13 | 4255.32 | -1491.81 (-25.96%) | 💔 |
To see the full report comment with /test benchmark fullreport
Author
|
@drewdaemon Thank you so much for your review!! We are planning on enhancing the dashboard later in a separate PR anyway so Im gonna address your comment then! Thanks again!! (I did crop the screenshot so no Grammarly logo there 😬 ) |
💚 Build Succeeded
History
|
|
66.7% Coverage on New Code|
Package aws - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=aws |
qcorporation
pushed a commit
that referenced
this pull request
Feb 3, 2025
qcorporation
pushed a commit
that referenced
this pull request
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR is to add a new integration for Amazon MSK.
Metrics available for MSK serverless cluster: https://docs.aws.amazon.com/msk/latest/developerguide/serverless-monitoring.html
Metrics available for general MSK cluster: https://docs.aws.amazon.com/msk/latest/developerguide/metrics-details.html
This integration collects all metrics available at the DEFAULT monitoring level and the basic dashboard only uses metrics available for MSK serverless clusters.
Checklist
changelog.ymlfile.Related issues
Screenshots