Skip to content

[AWS Guardduty] Update expired certificate in system test#8736

Merged
kcreddy merged 1 commit intoelastic:mainfrom
kcreddy:aws-guardduty-tests
Dec 16, 2023
Merged

[AWS Guardduty] Update expired certificate in system test#8736
kcreddy merged 1 commit intoelastic:mainfrom
kcreddy:aws-guardduty-tests

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented Dec 14, 2023

Proposed commit message

Check title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

$ elastic-package stack down && elastic-package build && elastic-package stack up --version=8.11.0 -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test system --generate -v 

--- Test results for package: aws - START ---
╭─────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ aws     │ guardduty   │ system    │ default   │ PASS   │ 40.104880125s │
╰─────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: aws - END   ---
Done

Related issues

Screenshots

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-14T11:53:37.361+0000

  • Duration: 84 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 223
Skipped 3
Total 226

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) ❕
Classes 94.444% (17/18) ❕
Methods 89.701% (270/301) ❕
Lines 86.083% (7571/8795) ❕
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 14, 2023

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kcreddy kcreddy marked this pull request as ready for review December 14, 2023 13:17
@kcreddy kcreddy requested review from a team as code owners December 14, 2023 13:18
@kcreddy kcreddy mentioned this pull request Dec 14, 2023
Merged
4 tasks
zmoog
zmoog approved these changes Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhapas
bhapas approved these changes Dec 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy merged commit 0353982 into elastic:main Dec 16, 2023
@kcreddy kcreddy deleted the aws-guardduty-tests branch February 7, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@efd6 efd6 efd6 approved these changes

@bhapas bhapas bhapas approved these changes

Assignees

No one assigned

Labels

Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kcreddy @elasticmachine @zmoog @efd6 @bhapas