Skip to content

[System][core] Enable tsdb#8637

Merged
tetianakravchenko merged 4 commits intoelastic:mainfrom
tetianakravchenko:system-core-enable-tsdb
Jan 12, 2024
Merged

[System][core] Enable tsdb#8637
tetianakravchenko merged 4 commits intoelastic:mainfrom
tetianakravchenko:system-core-enable-tsdb

Conversation

@tetianakravchenko
Copy link
Copy Markdown
Contributor

@tetianakravchenko tetianakravchenko commented Dec 4, 2023 •
edited
Loading

Proposed commit message

Enable TSDB by default for core datastream.
To enable tsdh on core datastream it is required to change the stack restriction to 8.11.0 - related to this issue elastic/elasticsearch#96552.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

system.core.id is a dimension now, there is no errors like Routing values must be strings but found (issue)
Screenshot 2023-12-04 at 10 57 13

@tetianakravchenko
enable tsdb on the system.core datastream
a7c57ff 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested review from a team as code owners December 4, 2023 10:04
@tetianakravchenko tetianakravchenko mentioned this pull request Dec 4, 2023
Closed
11 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 4, 2023 •
edited
Loading

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-05T09:18:06.769+0000

  • Duration: 21 min 5 sec

Test stats 🧪

Test Results
Failed 1
Passed 112
Skipped 0
Total 113

Test errors 1

Expand to view the tests failures

system test: default – system.process
    Expand to view the error details

     null

    Expand to view the stacktrace

     one or more errors found in documents stored in metrics-system.process-ep data stream: [0] field "system.process.num_threads" is undefined

Steps errors 2

Expand to view the steps failures

Test integration: system
  • Took 5 min 52 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 59.701% (40/67) ❕
Lines 98.426% (3002/3050) ❕
Conditionals 100.0% (0/0) 💚

@kush-elastic
Copy link
Copy Markdown
Contributor

kush-elastic commented Dec 21, 2023

/test

@mrodm
Copy link
Copy Markdown
Collaborator

mrodm commented Dec 21, 2023

Hi @tetianakravchenko, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@tetianakravchenko
merge in main; fix conflicts
cfc25de 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

tetianakravchenko commented Dec 22, 2023

CI is failing due to missing field in system.process datastream - here is a PR to add it #8783
@lalit-satapathy please help to review both PR and proceed with it

lalit-satapathy
lalit-satapathy approved these changes Jan 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tetianakravchenko
merge main and fix conflicts
dcdd434 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 12, 2024

🚀 Benchmarks report

Package system 👍(0) 💚(2) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
syslog 21739.13 16949.15 -4789.98 (-22.03%) 💔

To see the full report comment with /test benchmark fullreport

@tetianakravchenko tetianakravchenko merged commit 4743886 into elastic:main Jan 12, 2024
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 12, 2024

Package system - 1.53.0 containing this change is available at https://epr.elastic.co/search?package=system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

Assignees

No one assigned

Labels

Integration:system System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable TSDB for System integration

6 participants

@tetianakravchenko @elasticmachine @kush-elastic @mrodm @lalit-satapathy @andrewkroh