Skip to content

[system][process] Add missing num_threads field#8783

Merged
tetianakravchenko merged 4 commits intoelastic:mainfrom
tetianakravchenko:system-fix-ci
Jan 12, 2024
Merged

[system][process] Add missing num_threads field#8783
tetianakravchenko merged 4 commits intoelastic:mainfrom
tetianakravchenko:system-fix-ci

Conversation

@tetianakravchenko
Copy link
Copy Markdown
Contributor

Proposed commit message

Please explain:

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested review from a team as code owners December 21, 2023 12:25
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 21, 2023

🚀 Benchmarks report

Package system 👍(0) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
security 2262.44 1400.56 -861.88 (-38.1%) 💔
syslog 25000 9900.99 -15099.01 (-60.4%) 💔

To see the full report comment with /test benchmark fullreport

@lalit-satapathy
Copy link
Copy Markdown
Contributor

Assuming the es stack version of the fix elastic/beats#36578 is aligned. Otherwise LGTM.

@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

@ishleenk17 @elastic/security-external-integrations could you please have a look to this PR?

@ishleenk17
Copy link
Copy Markdown
Member

@tetianakravchenko : Since this has been checked into beats in October, last year. this will be available to users from 8.11 onwards.
Do we need to update the kibana version ?

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

tetianakravchenko commented Jan 4, 2024

@ishleenk17 I've set stack restriction to 8.11.0 - 0450f23 (checked that this field is available in v8.11.0 tag - https://github.com/elastic/beats/blob/v8.11.0/metricbeat/module/system/process/_meta/fields.yml )

@tetianakravchenko
Copy link
Copy Markdown
Contributor Author

@ishleenk17 can you please review it?

@elastic/security-external-integrations tests are failing because of the sytem.auth datastream due to the timestamp change:

-            "@timestamp": "2023-10-11T09:10:48.000Z",
+            "@timestamp": "2024-10-11T09:10:48.000Z",

could you please have a look to it?

@ishleenk17
Copy link
Copy Markdown
Member

The changes look good. Please resolve the build issue. Then we should be GTG

Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tetianakravchenko tetianakravchenko merged commit 71dd3e8 into elastic:main Jan 12, 2024
@tetianakravchenko tetianakravchenko deleted the system-fix-ci branch January 12, 2024 10:53
@elasticmachine
Copy link
Copy Markdown

Package system - 1.52.0 containing this change is available at https://epr.elastic.co/search?package=system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants