Skip to content

[integrations][Exchange Online Message Trace] - Refactored the integration and reworked the documentation#8550

Merged
ShourieG merged 7 commits intoelastic:mainfrom
ShourieG:message_trace/refactor
Nov 21, 2023
Merged

[integrations][Exchange Online Message Trace] - Refactored the integration and reworked the documentation#8550
ShourieG merged 7 commits intoelastic:mainfrom
ShourieG:message_trace/refactor

Conversation

@ShourieG
Copy link
Copy Markdown
Contributor

@ShourieG ShourieG commented Nov 21, 2023 •
edited
Loading

Type of change

  • Enhancement

Proposed commit message

Refactored the integration with the following changes:

  • Fixed httpjson template parsing issues by fixing value of the cursor. Initial interval is now respected for subsequent iterations.
  • Updated default values of scope and token endpoint to be in sync with the latest documentation.
  • Made template changes so that batch size value is correctly used.
  • Fixed broken pagination logic.
  • Reworked documentation to be more precise and descriptive.

Note

In addition to existing system tests, the changes were tested with a real world ms exchange account to validate whether logs were being accurately pulled or not. Screenshots of these are attached below.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-11-21 at 10 32 15 AM Screenshot 2023-11-21 at 10 32 57 AM Screenshot 2023-11-21 at 10 33 23 AM Screenshot 2023-11-21 at 9 05 38 PM Screenshot 2023-11-21 at 9 06 00 PM Screenshot 2023-11-21 at 9 06 32 PM

@ShourieG ShourieG requested a review from a team as a code owner November 21, 2023 09:13
@ShourieG ShourieG self-assigned this Nov 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 21, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ShourieG ShourieG added integration Label used for meta issues tracking each integration bugfix Pull request that fixes a bug issue labels Nov 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T15:31:01.386+0000

  • Duration: 36 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (15/15) 💚 9.434
Lines 98.106% (259/264) 👍 9.885
Conditionals 100.0% (0/0) 💚

bhapas
bhapas reviewed Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a screenshot of the doc changes from the Integration UI as well.

@ShourieG ShourieG added enhancement New feature or request and removed bugfix Pull request that fixes a bug issue labels Nov 21, 2023
@ShourieG
Copy link
Copy Markdown
Contributor Author

ShourieG commented Nov 21, 2023

@bhapas I've addressed all the PR suggestions

bhapas
bhapas approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit 5c34b10 into elastic:main Nov 21, 2023
@ShourieG ShourieG deleted the message_trace/refactor branch November 21, 2023 17:18
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 21, 2023

Package microsoft_exchange_online_message_trace - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_exchange_online_message_trace

@BenB196 BenB196 mentioned this pull request Dec 1, 2023
Closed
@BenB196 BenB196 mentioned this pull request Dec 13, 2023
Merged
6 tasks
@andrewkroh andrewkroh added the Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@ShourieG ShourieG

Labels

8.11 candidate enhancement New feature or request Integration:microsoft_exchange_online_message_trac Microsoft Exchange Online Message Trace integration Label used for meta issues tracking each integration

Projects

None yet

Milestone

No milestone

4 participants

@ShourieG @elasticmachine @bhapas @andrewkroh