[windows] - Cleanup fields.yml files#8099
Merged
andrewkroh merged 9 commits intoelastic:mainfrom Oct 5, 2023
andrewkroh:windows/feature/fields-cleanup
Merged
[windows] - Cleanup fields.yml files#8099andrewkroh merged 9 commits intoelastic:mainfrom andrewkroh:windows/feature/fields-cleanup
andrewkroh merged 9 commits intoelastic:mainfrom
andrewkroh:windows/feature/fields-cleanup
Conversation
[git-generate] cd packages/windows elastic-package format
[git-generate] perl -p -i -e 's/exernal:/external:/g' packages/windows/**/fields/*.yml
[git-generate] go run github.com/andrewkroh/fydler@e90f903 -fix -a unknownattribute packages/windows/**/fields/*.yml cd packages/windows elastic-package format
[git-generate] go run github.com/andrewkroh/fydler@e90f903 -fix -a useecs packages/windows/**/fields/*.yml cd packages/windows elastic-package format
The description does not get used by anything (not in docs, mappings, fleet). [git-generate] go run github.com/andrewkroh/fydler@e90f903 -fix -a invalidattribute packages/windows/**/fields/*.yml cd packages/windows elastic-package format
packages/windows/data_stream/applocker_exe_and_dll/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/applocker_exe_and_dll/fields/ecs.yml:55:3 additional definition (duplicate) packages/windows/data_stream/applocker_msi_and_script/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/applocker_msi_and_script/fields/ecs.yml:55:3 additional definition (duplicate) packages/windows/data_stream/applocker_packaged_app_deployment/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/applocker_packaged_app_deployment/fields/ecs.yml:57:3 additional definition (duplicate) packages/windows/data_stream/applocker_packaged_app_execution/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/applocker_packaged_app_execution/fields/ecs.yml:57:3 additional definition (duplicate) packages/windows/data_stream/forwarded/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/forwarded/fields/ecs.yml:119:3 additional definition (duplicate) packages/windows/data_stream/powershell/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/powershell/fields/ecs.yml:39:3 additional definition (duplicate) packages/windows/data_stream/powershell_operational/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/powershell_operational/fields/ecs.yml:39:3 additional definition (duplicate) packages/windows/data_stream/sysmon_operational/fields/agent.yml:49:7 host.name is declared 2 times (duplicate) packages/windows/data_stream/sysmon_operational/fields/ecs.yml:115:3 additional definition (duplicate)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Member
Author
|
Regarding the validation failure, I logged an issue at elastic/elastic-package#1488. I will remove the changes to the |
[git-generate] cd packages/windows elastic-package build
[git-generate] elastic-package changelog add --link #8099 --next minor --type enhancement --description 'Modified the field definitions to reference ECS where possible and remove invalid field attributes.'
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
approved these changes
Oct 5, 2023
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
cmacknz
approved these changes
Oct 5, 2023
|
Package windows - 1.38.0 containing this change is available at https://epr.elastic.co/search?package=windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This cleans up the field definitions for the package.
Fix typo in 'external' field attribute.
Remove unnecessary attributes like
requiredorlevel.Use
external: ecsfor any field that exists in ECS.Remove
descriptionfrom field groups. The description does not get used by anything (not in docs, mappings, fleet).Remove duplicate field declarations.
Replace dotted YAML key
kibana.versionin manifest.yml.Checklist
changelog.ymlfile.