Skip to content

[O11y][Nats] Migrate Logs Overview dashboard visualizations to lens#8086

Merged
rajvi-patel-22 merged 1 commit intoelastic:mainfrom
rajvi-patel-22:lens_migration_nats_logs
Oct 5, 2023
Merged

[O11y][Nats] Migrate Logs Overview dashboard visualizations to lens#8086
rajvi-patel-22 merged 1 commit intoelastic:mainfrom
rajvi-patel-22:lens_migration_nats_logs

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Oct 4, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Nats visualizations to the lens in the current Kibana version 8.10.2 itself.

  • Statistics for Nats Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Logs NATS] Overview 0 9 8 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.2 itself.

Related issues

Note

Before Migration:
screencapture-localhost-56394-app-dashboards-2023-10-04-19_00_28

After Migration:
image

@rajvi-patel-22 rajvi-patel-22 self-assigned this Oct 4, 2023
@rajvi-patel-22 rajvi-patel-22 requested a review from a team October 4, 2023 09:31
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 4, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T09:30:09.560+0000

  • Duration: 31 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 46
Skipped 2
Total 48

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚 75.0
Lines 95.522% (192/201) 👎 -4.478
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review October 4, 2023 12:09
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner October 4, 2023 12:09
@constanca-m
Copy link
Copy Markdown
Contributor

constanca-m commented Oct 4, 2023

Hey @rajvi-elastic , can you include a screenshot of the results before and after?

@rajvi-patel-22
Copy link
Copy Markdown
Contributor Author

rajvi-patel-22 commented Oct 4, 2023

Hey @rajvi-elastic , can you include a screenshot of the results before and after?

@constanca-m, I have added screenshots in description.

kush-elastic
kush-elastic approved these changes Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 9a6fcf2 into elastic:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@constanca-m constanca-m constanca-m approved these changes

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko was automatically assigned from elastic/obs-cloudnative-monitoring

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

Integration:nats NATS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rajvi-patel-22 @elasticmachine @constanca-m @kush-elastic @andrewkroh