Skip to content

iptables: ensure event.kind is correctly set for pipeline errors#6642

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:6547-iptables
Jun 21, 2023
Merged

iptables: ensure event.kind is correctly set for pipeline errors#6642
efd6 merged 2 commits intoelastic:mainfrom
efd6:6547-iptables

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Jun 20, 2023

What does this PR do?

Modify iptables to correctly set event.kind for pipeline errors and ensure error.message is an array.

Change testing docker image to provide a journald that is compatible with beats.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

efd6 added 2 commits June 21, 2023 08:53
@efd6
iptables: use ubuntu20.04 image for journald
0340842 
The version of journald in debian-slim does not appear to be compatible
with the version handled by filebeat, so backup to 20.04.
@efd6
iptables: ensure event.kind is correctly set for pipeline errors
470da5e
@efd6 efd6 added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations labels Jun 20, 2023
@efd6 efd6 self-assigned this Jun 20, 2023
@efd6 efd6 mentioned this pull request Jun 20, 2023
Closed
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T23:29:38.653+0000

  • Duration: 16 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 5.172
Classes 100.0% (1/1) 💚 5.172
Methods 100.0% (16/16) 💚 4.332
Lines 92.453% (294/318) 👍 1.491
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 20, 2023 23:54
@efd6 efd6 requested a review from a team as a code owner June 20, 2023 23:54
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 3c49ad1 into elastic:main Jun 21, 2023
@jsoriano jsoriano mentioned this pull request Jun 23, 2023
Merged
@efd6 efd6 deleted the 6547-iptables branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@kgeller kgeller kgeller approved these changes

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues enhancement New feature or request Integration:iptables Iptables

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iptables] journald input system tests failing

4 participants

@efd6 @elasticmachine @andrewkroh @kgeller