Skip to content

[ti_abusech] Ensure event.kind is correctly set for pipeline errors#6629

Merged
efd6 merged 6 commits intoelastic:mainfrom
MakoWish:6582-ti_abusech
Jun 21, 2023
Merged

[ti_abusech] Ensure event.kind is correctly set for pipeline errors#6629
efd6 merged 6 commits intoelastic:mainfrom
MakoWish:6582-ti_abusech

Conversation

@MakoWish
Copy link
Copy Markdown
Contributor

What does this PR do?

Modify ti_abusech integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 20, 2023 20:03
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T01:33:14.522+0000

  • Duration: 16 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Jun 20, 2023

/test

@MakoWish
Copy link
Copy Markdown
Contributor Author

Missed a closing double quote on the changelog. Fixed.

@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Jun 21, 2023

/test

@elasticmachine
Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 5.172
Classes 100.0% (4/4) 💚 5.172
Methods 100.0% (51/51) 💚 4.332
Lines 89.636% (493/550) 👎 -1.325
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit e553e90 into elastic:main Jun 21, 2023
@elasticmachine
Copy link
Copy Markdown

Package ti_abusech - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=ti_abusech

@MakoWish MakoWish deleted the 6582-ti_abusech branch June 21, 2023 14:23
qcorporation added a commit that referenced this pull request Nov 14, 2025
…ormat variations (#15985)

* Update aruba to handle optional syslog priority and format variations in procid fields
- parsed the priority field introduced within some CX switches
- extracted prod_id into it's own pattern_definition for readability

Test Cases:
- validated that for <xxx>1 that the priority field is being parsed out. Note the "count" value after the angle bracket is not being parsed to a field
- validated that all pipeline test pass
tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
…od_id format variations (elastic#15985)

* Update aruba to handle optional syslog priority and format variations in procid fields
- parsed the priority field introduced within some CX switches
- extracted prod_id into it's own pattern_definition for readability

Test Cases:
- validated that for <xxx>1 that the priority field is being parsed out. Note the "count" value after the angle bracket is not being parsed to a field
- validated that all pipeline test pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants