[System] [Network] Add dimensions and clean up duplicated fields definition#6405
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
| description: > | ||
| OS codename, if any. | ||
|
|
||
| - name: network.in.bytes |
There was a problem hiding this comment.
those fields are repeated in fields/ twice: in agent.yml and in fields.yml
| - name: data_stream.namespace | ||
| type: constant_keyword | ||
| description: Data stream namespace. | ||
| - name: '@timestamp' |
There was a problem hiding this comment.
| type: group | ||
| fields: | ||
| - name: network.in.bytes | ||
| type: scaled_float |
There was a problem hiding this comment.
see this comment for reference - #6118 (comment)
There was a problem hiding this comment.
My understanding based on the previous comments is that the only affect this has is on the docs page, everything else already had long. Correct?
There was a problem hiding this comment.
Yes, I have the same understanding, all the host.network.in.*, host.network.out.* are of type long when instaling package:
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
packages/system/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.30.0" | |||
There was a problem hiding this comment.
Same as other PR, conflicting version number?
ruflin
left a comment
There was a problem hiding this comment.
Change LGTM.
But see my comment around package version.
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
Package system - 1.32.0-beta.1 containing this change is available at https://epr.elastic.co/search?package=system |
…nition (#6405) * add dimensions and clean up duplicated fields definition Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * fix pr link in changelog Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
What does this PR do?
This is a follow up PR of #6118 (comment)
In this PR:
system.network.nameChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots