[Cisco IOS] Adding Timezone Map advanced option#6356
Merged
P1llus merged 9 commits intoelastic:mainfrom Jun 1, 2023
Merged
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kcreddy
reviewed
May 29, 2023
packages/cisco_ios/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
Co-authored-by: Chema Martínez <chema.martinez@elastic.co>
Co-authored-by: Chema Martínez <chema.martinez@elastic.co>
chemamartinez
approved these changes
Jun 1, 2023
|
Package cisco_ios - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ios |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
* [Cisco IOS] Adding Timezone Map advanced option, and cleaning up pipeline a bit * changelog * slight modification to ensure it continues if tz_offset does not exist * modified painless slightly to fix typo * adding TZ Map to all input types * Update packages/cisco_ios/_dev/build/docs/README.md Co-authored-by: Chema Martínez <chema.martinez@elastic.co> * Update packages/cisco_ios/docs/README.md Co-authored-by: Chema Martínez <chema.martinez@elastic.co> * no need to bump version higher anymore, as no dashboards --------- Co-authored-by: Chema Martínez <chema.martinez@elastic.co>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the possibility for larger deployments to support multiple timezones per integration. The main issue is that the format Cisco IOS logs timezones is not supported by common programming languages (AEST etc, rather than +0200), so this PR adds the possibility to create a map of all the timezones they want to support.
This is simply an extension to tz_offset, and is most likely not useful in most scenarios, so normal users will simply continue to use tz_offset instead.
Added system tests for all possible scenarios as well (all the different tz combinations).
Checklist
changelog.ymlfile.