[AWS] Add metric type to Usage, DynamoDB and ELB data streams#6296
Merged
constanca-m merged 4 commits intoelastic:mainfrom Jun 6, 2023
Merged
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
18 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
tetianakravchenko
approved these changes
Jun 1, 2023
francescayeye
approved these changes
Jun 5, 2023
packages/aws/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.36.9" | |||
There was a problem hiding this comment.
nit: in #6365 we bumped minor version, here only patch one
why the difference? :)
Contributor
Author
There was a problem hiding this comment.
1.36.x are all related to TSDB, unlike what happened in #6365. That is why I changed the way I was bumping the version.
Contributor
Author
|
/test |
|
Package aws - 1.40.3 containing this change is available at https://epr.elastic.co/search?package=aws |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Add metric type. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update changelog. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> --------- Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add metric type to Usage, DynamoDB and ELB data streams.
All metric fields were set as of having type gauge. Even though some fields seem to be counters, they are only cumulative over a very specific window of time - for example, 1 minute or 5 minutes. This causes a value to be incrementing and decrementing over time, instead of staying equal or higher to the previous value, which would be necessary if we were facing a counter field.
As an example, we have
ConsumedReadCapacityUnits.sum(by definition, "The number of read capacity units consumed over the specified time period"), that would look like this for each table:Checklist
changelog.ymlfile.How to test this PR locally
Refer to #6227.
Related issues
Relates to #6227.