Skip to content

[O11y][Redis] Migrate Metrics Overview dashboard visualizations to lens in kibana 8.3.0#5658

Merged
kush-elastic merged 7 commits intoelastic:mainfrom
chavdaharnish:lens_migration-redis-metrics_overview-8.3.0
Apr 11, 2023
Merged

[O11y][Redis] Migrate Metrics Overview dashboard visualizations to lens in kibana 8.3.0#5658
kush-elastic merged 7 commits intoelastic:mainfrom
chavdaharnish:lens_migration-redis-metrics_overview-8.3.0

Conversation

@harnish-crest-data
Copy link
Copy Markdown
Contributor

@harnish-crest-data harnish-crest-data commented Mar 23, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Redis integration package

  • Statistics for Redis Lens migration:

Redis dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics Redis] Overview 0 7 7 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.3.0.

Related issues

Issues Identified

Note : - There is no screenshot previously present for Metrics Overview dashboard. Hence we have updated the screenshot and also updated entry in manifest.yml file. Please refer before migration for compare and review.

image

@harnish-crest-data harnish-crest-data changed the title [O11y] Migrate Metrics Overview dashboard visualizations to lens in kibana 8.3.0 [O11y][Redis] Migrate Metrics Overview dashboard visualizations to lens in kibana 8.3.0 Mar 23, 2023
@kush-elastic kush-elastic added enhancement New feature or request v8.3.0 Team:Service-Integrations Label for the Observability Service Integrations team labels Mar 23, 2023
@kush-elastic kush-elastic mentioned this pull request Mar 23, 2023
Closed
7 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-11T05:45:18.644+0000

  • Duration: 14 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 50.0
Classes 100.0% (1/1) 💚 50.0
Methods 66.667% (14/21) 👎 -3.333
Lines 94.186% (81/86) 👍 23.952
Conditionals 100.0% (0/0) 💚

@harnish-crest-data harnish-crest-data marked this pull request as ready for review March 23, 2023 12:39
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner March 23, 2023 12:39
kush-elastic
kush-elastic approved these changes Mar 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Mar 24, 2023

Please note the labels in the panel is getting truncated right after the second character.

It may be best to either put the labels either at the bottom or have two panels per row.

image

agithomas
agithomas reviewed Mar 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the phrase 'Metrics' from the string Metrics Overview in the changelog.

@harnish-crest-data
Copy link
Copy Markdown
Contributor Author

harnish-crest-data commented Mar 24, 2023

Please note the labels in the panel is getting truncated right after the second character.

It may be best to either put the labels either at the bottom or have two panels per row.

image

We have kept the same behavior with the previous visualization. We totally agreed on your point and we have created separate issue for that as well. Once all redis migration PRs are approved and merged we will work on that issue.

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 24, 2023
Closed
6 tasks
agithomas
agithomas approved these changes Mar 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-crest-data
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
c029782 
…into lens_migration-redis-metrics_overview-8.3.0

Conflicts:
	packages/redis/changelog.yml
	packages/redis/manifest.yml
@harnish-crest-data
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
817c154 
…into lens_migration-redis-metrics_overview-8.3.0

Conflicts:
	packages/redis/changelog.yml
	packages/redis/manifest.yml
@kush-elastic kush-elastic merged commit d4ffd82 into elastic:main Apr 11, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 11, 2023

Package redis - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

enhancement New feature or request Integration:redis Redis Team:Service-Integrations Label for the Observability Service Integrations team v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harnish-crest-data @elasticmachine @agithomas @kush-elastic