Skip to content

[AWS] Migrate EC2 metrics dashboard to lenses#5626

Merged
gpop63 merged 5 commits intoelastic:mainfrom
gpop63:aws-ec2_metrics_lenses
Jun 7, 2023
Merged

[AWS] Migrate EC2 metrics dashboard to lenses#5626
gpop63 merged 5 commits intoelastic:mainfrom
gpop63:aws-ec2_metrics_lenses

Conversation

@gpop63
Copy link
Copy Markdown
Contributor

@gpop63 gpop63 commented Mar 22, 2023

What does this PR do?

Migrates visualizations to lenses and adds input control groups.
I used https://github.com/elastic/elastic-integration-corpus-generator-tool/ to generate random data stream data. For some reason old visualizations would not show the data in the dashboard so the before image would be empty panels.

Before:
ec2_metrics_before

After:
ec2_metrics_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T19:11:30.302+0000

  • Duration: 52 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -0.694
Classes 93.75% (15/16) 👎 -0.694
Methods 85.921% (238/277) 👎 -0.948
Lines 85.925% (7387/8597) 👎 -0.654
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Mar 22, 2023
@gpop63 gpop63 marked this pull request as ready for review March 22, 2023 18:48
@gpop63 gpop63 requested review from a team as code owners March 22, 2023 18:48
drewdaemon
drewdaemon reviewed Apr 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gpop63 ! Glad to see this!

How would you feel about the following changes?

  • move the EC2 CPU Utilization visualization to the right of the instance state pie chart and status check failed metric. Make the EC2 CPU Utilization vis take up half the screen, with the others taking up 1/4 each.
  • transpose the bottom four visualizations such that Network In Bytes is vertically above Network out bytes and DiskIO Read Bytes is above Disk IO Write Bytes. This should make comparisons between the members of each pair easier since they will be aligned along the same time axis.

@botelastic
Copy link
Copy Markdown

botelastic bot commented May 6, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 6, 2023
@drewdaemon
Copy link
Copy Markdown
Contributor

drewdaemon commented May 18, 2023

From meeting

  • convert pie chart to treemap
  • convert metric to new metric type
  • make pie chart panel wider so metric is smaller

@botelastic botelastic bot removed the Stalled label May 18, 2023
@gpop63 gpop63 self-assigned this May 22, 2023
@gpop63
Copy link
Copy Markdown
Contributor Author

gpop63 commented May 29, 2023

New layout:

ec2_new_layout

@gpop63 gpop63 merged commit 7fbfdab into elastic:main Jun 7, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jun 7, 2023

Package aws - 1.40.8 containing this change is available at https://epr.elastic.co/search?package=aws

@harnish-crest-data harnish-crest-data mentioned this pull request Jun 9, 2023
Closed
5 tasks
sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@gpop63 @sodhikirti07
[AWS] Migrate EC2 metrics dashboard to lenses (#5626)
6a34bf0 
* add lenses

* bump package version

* fix layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

@gpop63 gpop63

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gpop63 @elasticmachine @drewdaemon @zmoog