system: convert dashboard visualisations to store by value#5322
Merged
efd6 merged 1 commit intoelastic:mainfrom Mar 14, 2023
Merged
system: convert dashboard visualisations to store by value#5322efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
The git-generate script requires yarn to be installed. [git-generate] cd packages/system/ elastic-package stack down && elastic-package stack up --version=8.1.0 -d -v git clone --depth=1 https://github.com/flash1293/legacy_vis_analyzer.git ( cd legacy_vis_analyzer git submodule update --depth=1 --init --recursive yarn KIBANA="https://elastic:changeme@localhost:5601" NODE_TLS_REJECT_UNAUTHORIZED='0' node inline.js ../kibana/ ) rm -rf legacy_vis_analyzer gsed -i -r 's/^version: 1\.[0-9]+\.[0-9]+$/version: 1.25.0/' manifest.yml gsed -i '/^# newer versions go on top$/d' changelog.yml echo '# newer versions go on top' >changelog.yml~ cat <<EOF | cat - changelog.yml >>changelog.yml~ && mv changelog.yml{~,} - version: "1.25.0" changes: - description: Convert dashboard visualisations to storage by value. type: enhancement link: elastic#5322 EOF
drewdaemon
approved these changes
Mar 10, 2023
Contributor
drewdaemon
left a comment
There was a problem hiding this comment.
Great work. Just for visibility, there is automated tooling to accomplish this.
andrewkroh
approved these changes
Mar 13, 2023
Contributor
Author
|
@drewdaemon That package is the same as the one that I used here, correct? |
fearful-symmetry
approved these changes
Mar 13, 2023
|
Package system - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=system |
Contributor
|
@efd6 great! There's no way for me to know if you used the tool or did it in the dashboard UI, so I wanted to make sure you knew. |
Contributor
Author
|
@drewdaemon The commit message has a git-generate script which re-runs the process and shows what was done (excellent tool). |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 20, 2023
) The git-generate script requires yarn to be installed. [git-generate] cd packages/system/ elastic-package stack down && elastic-package stack up --version=8.1.0 -d -v git clone --depth=1 https://github.com/flash1293/legacy_vis_analyzer.git ( cd legacy_vis_analyzer git submodule update --depth=1 --init --recursive yarn KIBANA="https://elastic:changeme@localhost:5601" NODE_TLS_REJECT_UNAUTHORIZED='0' node inline.js ../kibana/ ) rm -rf legacy_vis_analyzer gsed -i -r 's/^version: 1\.[0-9]+\.[0-9]+$/version: 1.25.0/' manifest.yml gsed -i '/^# newer versions go on top$/d' changelog.yml echo '# newer versions go on top' >changelog.yml~ cat <<EOF | cat - changelog.yml >>changelog.yml~ && mv changelog.yml{~,} - version: "1.25.0" changes: - description: Convert dashboard visualisations to storage by value. type: enhancement link: elastic#5322 EOF
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Mar 21, 2023
) The git-generate script requires yarn to be installed. [git-generate] cd packages/system/ elastic-package stack down && elastic-package stack up --version=8.1.0 -d -v git clone --depth=1 https://github.com/flash1293/legacy_vis_analyzer.git ( cd legacy_vis_analyzer git submodule update --depth=1 --init --recursive yarn KIBANA="https://elastic:changeme@localhost:5601" NODE_TLS_REJECT_UNAUTHORIZED='0' node inline.js ../kibana/ ) rm -rf legacy_vis_analyzer gsed -i -r 's/^version: 1\.[0-9]+\.[0-9]+$/version: 1.25.0/' manifest.yml gsed -i '/^# newer versions go on top$/d' changelog.yml echo '# newer versions go on top' >changelog.yml~ cat <<EOF | cat - changelog.yml >>changelog.yml~ && mv changelog.yml{~,} - version: "1.25.0" changes: - description: Convert dashboard visualisations to storage by value. type: enhancement link: elastic#5322 EOF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates visualisations to store by value.
The operations used are shown in the
git-generatescript in the commit message and can be confirmed (slowly) by runninggit generate.Output of script from point of cloning the conversion tool.
Details
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Install integrations and examine dashboards.
Related issues
Screenshots