Merged
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
andrewkroh
reviewed
Jan 21, 2021
Member
andrewkroh
left a comment
There was a problem hiding this comment.
This looks good. Can you please update this with TCP and UDP syslog tests now that there's a way to add multiple tests. You can see an example in #553. If you have any suggestions for improvements let me know.
andrewkroh
reviewed
Feb 1, 2021
Member
|
Closes #645 |
89 tasks
andrewkroh
reviewed
Feb 18, 2021
Member
andrewkroh
left a comment
There was a problem hiding this comment.
Just a few minor comments regarding the config UI. Other than that, looks good to go 👍 .
andrewkroh
approved these changes
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds XG dataset to sophos integrations
Checklist
Author's Checklist
Related