Skip to content

panw*,pulse_connect_secure: remove duplicate fields#4633

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:4398-p
Nov 14, 2022
Merged

panw*,pulse_connect_secure: remove duplicate fields#4633
efd6 merged 2 commits intoelastic:mainfrom
efd6:4398-p

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Nov 14, 2022

What does this PR do?

This removes duplicate field definitions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:pulse_connect_secure Pulse Connect Secure (Community supported) labels Nov 14, 2022
@efd6 efd6 self-assigned this Nov 14, 2022
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-14T07:46:56.241+0000

  • Duration: 18 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 67
Skipped 0
Total 67

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022 •
edited
Loading

🚀 Benchmarks report

Package panw 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
panos 991.08 530.5 -460.58 (-46.47%) 💔

Package panw_cortex_xdr 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
alerts 2188.18 1157.41 -1030.77 (-47.11%) 💔

Package pulse_connect_secure 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 3610.11 2481.39 -1128.72 (-31.27%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (17/17) 💚 2.53
Classes 100.0% (17/17) 💚 2.53
Methods 98.969% (96/97) 👍 8.088
Lines 94.156% (3738/3970) 👍 2.46
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 14, 2022 08:11
@efd6 efd6 requested a review from a team as a code owner November 14, 2022 08:11
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 14, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 5560f1d into elastic:main Nov 14, 2022
@efd6 efd6 mentioned this pull request Nov 15, 2022
Closed
60 tasks
@efd6 efd6 deleted the 4398-p branch February 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees

@efd6 efd6

Labels

bug Something isn't working, use only for issues Integration:panw_cortex_xdr Palo Alto Cortex XDR Integration:panw Palo Alto Next-Gen Firewall Integration:pulse_connect_secure Pulse Connect Secure (Community supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6 @elasticmachine @marc-gr