Skip to content

Updating dependency on elastic-package#395

Merged
mtojek merged 7 commits intoelastic:masterfrom
ycombinator:test-report-folder
Nov 16, 2020
Merged

Updating dependency on elastic-package#395
mtojek merged 7 commits intoelastic:masterfrom
ycombinator:test-report-folder

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Nov 9, 2020 •
edited
Loading

What does this PR do?

This PR updates the dependency on elastic-package for changing the location of where test reports are stored (elastic/elastic-package#158).

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 9, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #395 updated]

  • Start Time: 2020-11-16T11:27:31.165+0000

  • Duration: 8 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Nov 10, 2020

Hm... it looks like a non standard error:

[2020-11-09T09:57:55.269Z] Error: building package failed: building package failed (root: /var/lib/jenkins/workspace/gest-manager_integrations_PR-395/src/github.com/elastic/integrations/packages/apache): locating build directory failed: stat /var/lib/jenkins/workspace/gest-manager_integrations_PR-395/src/github.com/elastic/integrations/build/integrations: no such file or directory
[2020-11-09T09:57:55.269Z] Error: running elastic-package failed: running "/var/lib/jenkins/workspace/gest-manager_integrations_PR-395/src/github.com/elastic/integrations/build/elastic-package build" failed with exit code 1

@andresrc andresrc requested a review from mtojek November 10, 2020 09:44
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Nov 11, 2020

Thanks @mtojek, I'm going to try and repro that error locally and update this PR as necessary.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Nov 11, 2020

run tests

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Nov 11, 2020

I'm unable to reproduce this locally. If I run mage build the packages are built as expected.

@mtojek would you mind trying on your end please? If it works for you locally as well, I'll start adding some debugging statements to see what's going on in CI.

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Nov 12, 2020 •
edited
Loading

I replicated the problem:

➜  integrations git:(test-report-folder) mage clean
➜  integrations git:(test-report-folder) mage build
packages/apache:
go: downloading github.com/elastic/elastic-package v0.0.0-20201109090234-263248735c28
elastic-package build
elastic-package has been installed.
Build the package
Error: building package failed: building package failed (root: /Users/marcin.tojek/go/src/github.com/elastic/integrations/packages/apache): locating build directory failed: stat /Users/marcin.tojek/go/src/github.com/elastic/integrations/build/integrations: no such file or directory
Error: running elastic-package failed: running "/Users/marcin.tojek/go/src/github.com/elastic/integrations/build/elastic-package build" failed with exit code 1

It looks like a bug around build/integrations which is missing and should be created by the elastic-package.

EDIT:

I think that the revision of the elastic-package contains a bug in the source. If the build directory exists, but build/integrations doesn't, it won't create it but fail the elastic-package build.

mtojek
mtojek suggested changes Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that the elastic-package needs a fix in code.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Nov 12, 2020

After running mage clean, I'm able to reproduce the issue locally as well. Thanks @mtojek. I'll work on a fix PR to elastic-package.

@ycombinator ycombinator mentioned this pull request Nov 13, 2020
Merged
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Nov 13, 2020

PR to fix elastic-package: elastic/elastic-package#172

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Nov 16, 2020

I'm afraid that sth is still wrong here.

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Nov 16, 2020

I'm afraid that sth is still wrong here.

Yup, I've been working on the fix: elastic/elastic-package#173.

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Nov 16, 2020 •
edited
Loading

Would you mind bumping the dependency one more revision up to include changes in elastic/elastic-package#171 ?

@ycombinator ycombinator requested a review from mtojek November 16, 2020 10:25
mtojek
mtojek reviewed Nov 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an update in go.mod is required.

@ycombinator ycombinator requested a review from mtojek November 16, 2020 11:41
@mtojek mtojek merged commit 3e39f05 into elastic:master Nov 16, 2020
@ycombinator ycombinator mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ycombinator @elasticmachine @mtojek